Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 7748017: base: Add AsBinary() function to Value API. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

base: Add AsBinary() function to Value API. This function should simplify some constructions. Instead of: if (!value->IsType(Value::TYPE_BINARY)) return false; BinaryValue* binary_value = static_cast<BinaryValue*>(value); You can do: BinaryValue* binary_value = value->AsBinary(); if (!binary_value) return false; BUG=None TEST=base_unittests --gtest_filter=Values* R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98266

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M base/values.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/values.cc View 7 chunks +14 lines, -6 lines 0 comments Download
M base/values_unittest.cc View 1 chunk +6 lines, -7 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 4 months ago (2011-08-25 15:10:29 UTC) #1
Evan Martin
9 years, 4 months ago (2011-08-25 15:18:36 UTC) #2
LGTM

http://codereview.chromium.org/7748017/diff/1001/base/values_unittest.cc
File base/values_unittest.cc (right):

http://codereview.chromium.org/7748017/diff/1001/base/values_unittest.cc#newc...
base/values_unittest.cc:425: original_binary->GetSize()));
new code is a lot better!

Powered by Google App Engine
This is Rietveld 408576698