base: Add AsBinary() function to Value API.

base/values_unittest.cc

Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index c8d3e3ca11d6429731a3c5b718a73bfe27911122..0ca19d9d2b626b96b4ffb0f9f83008590c7ef430 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -416,14 +416,13 @@ TEST(ValuesTest, DeepCopy) {
   ASSERT_TRUE(copy_dict->Get("binary", &copy_binary));
   ASSERT_TRUE(copy_binary);
   ASSERT_NE(copy_binary, original_binary);
-  ASSERT_TRUE(copy_binary->IsType(Value::TYPE_BINARY));
-  ASSERT_NE(original_binary->GetBuffer(),
-    static_cast<BinaryValue*>(copy_binary)->GetBuffer());
-  ASSERT_EQ(original_binary->GetSize(),
-    static_cast<BinaryValue*>(copy_binary)->GetSize());
+  BinaryValue* binary_value = copy_binary->AsBinary();
+  ASSERT_TRUE(binary_value);
+  ASSERT_NE(original_binary->GetBuffer(), binary_value->GetBuffer());
+  ASSERT_EQ(original_binary->GetSize(), binary_value->GetSize());
   ASSERT_EQ(0, memcmp(original_binary->GetBuffer(),
-               static_cast<BinaryValue*>(copy_binary)->GetBuffer(),
-               original_binary->GetSize()));
+                      binary_value->GetBuffer(),
+                      original_binary->GetSize()));

[Evan Martin, 2011/08/25 15:18:36]

new code is a lot better!

 
   Value* copy_value = NULL;
   ASSERT_TRUE(copy_dict->Get("list", &copy_value));