chrome/browser/chromeos/extensions/file_browser_event_router.cc - Issue 7748003: Show only one error notification per inserted mulitpartitioned usb card.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_browser_event_router.cc

Issue 7748003: Show only one error notification per inserted mulitpartitioned usb card. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: "We can leave HideFileBrowserNotification calls as they were" Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/file_browser_event_router.cc

diff --git a/chrome/browser/chromeos/extensions/file_browser_event_router.cc b/chrome/browser/chromeos/extensions/file_browser_event_router.cc

index b33912fe1f771f49d948bdb40989bdfaf372a5fb..5c0fc9954d8f42ccc44958b13d7bc27cdd1256d7 100644

--- a/chrome/browser/chromeos/extensions/file_browser_event_router.cc

+++ b/chrome/browser/chromeos/extensions/file_browser_event_router.cc

@@ -210,12 +210,15 @@ void ExtensionFileBrowserEventRouter::MountCompleted(

chromeos::MountLibrary::Disk* disk =

mount_lib->disks().find(mount_info.source_path)->second;

+ std::string notification_sys_path =

+ disk->system_path().substr(0, disk->system_path().rfind("/block"));

zel 2011/08/25 13:50:47 /block feels bit too platform specific. i.e. new k

if (!error_code) {

HideFileBrowserNotification("MOUNT", disk->system_path());

} else {

HideFileBrowserNotification("MOUNT", disk->system_path());

if (!disk->drive_label().empty()) {

- ShowFileBrowserNotification("MOUNT", disk->system_path(),

+ ShowFileBrowserNotification("MOUNT", notification_sys_path,

zel 2011/08/25 13:50:47 make "MOUNT' constant

IDR_PAGEINFO_INFO,

l10n_util::GetStringUTF16(IDS_REMOVABLE_DEVICE_DETECTION_TITLE),

// TODO(tbarzic): Find more suitable message.

@@ -224,7 +227,7 @@ void ExtensionFileBrowserEventRouter::MountCompleted(

ASCIIToUTF16(disk->drive_label()),

ASCIIToUTF16(MountErrorToString(error_code))));