Fix flakey test by making sure WebUI dialog is shut down before test completion.

chrome/browser/printing/print_dialog_cloud_uitest.cc

Index: chrome/browser/printing/print_dialog_cloud_uitest.cc
diff --git a/chrome/browser/printing/print_dialog_cloud_uitest.cc b/chrome/browser/printing/print_dialog_cloud_uitest.cc
index a1285e530f6115da051374212d3020dfb50f26af..bb3bcc6052e2088e63f2c0b15b24336c96593a31 100644
--- a/chrome/browser/printing/print_dialog_cloud_uitest.cc
+++ b/chrome/browser/printing/print_dialog_cloud_uitest.cc
@@ -236,6 +236,11 @@ IN_PROC_BROWSER_TEST_F(PrintDialogCloudTest, HandlersRegistered) {
   ui_test_utils::RunMessageLoop();
 
   ASSERT_TRUE(TestController::GetInstance()->result());
+
+  // Close the dialog before finishing the test.

[willchan no longer on Chromium, 2011/08/26 11:47:15]

While this will fix the test, which is a good thing, I think it begs the
question of why browser shutdown doesn't clean up all the relevant resources
cleanly. I hope there's an open bug for this.

+  EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE,
+                                              false, false, false, false));
+  ui_test_utils::WaitForNotification(content::NOTIFICATION_TAB_CLOSED);

[Paweł Hajdan Jr., 2011/08/26 21:52:26]

Please use WindowedNotificationObserver to avoid any possible raciness.

[Scott Byer, 2011/08/27 19:28:04]

Done.  Thanks! That solved he Windows try bot issue. Don't need to fix a timing
issue by adding another one!

 }
 
 #if defined(OS_CHROMEOS)