Fix flakey test by making sure WebUI dialog is shut down before test completion.

chrome/browser/printing/print_dialog_cloud_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_dialog_cloud.h"
 #include "chrome/browser/printing/print_dialog_cloud_internal.h"
 
 #include <functional>
 
 #include "base/file_path.h"
@@ skipping 218 matching lines @@
   BrowserList::SetLastActive(browser());
   ASSERT_TRUE(BrowserList::GetLastActive());
 
   AddTestHandlers();
 
   TestController::GetInstance()->set_use_delegate(true);
 
   ui_test_utils::RunMessageLoop();
 
   ASSERT_TRUE(TestController::GetInstance()->result());
+
+  // Close the dialog before finishing the test.

[willchan no longer on Chromium, 2011/08/26 11:47:15]

While this will fix the test, which is a good thing, I think it begs the
question of why browser shutdown doesn't clean up all the relevant resources
cleanly. I hope there's an open bug for this.

+  EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE,
+                                              false, false, false, false));
+  ui_test_utils::WaitForNotification(content::NOTIFICATION_TAB_CLOSED);

[Paweł Hajdan Jr., 2011/08/26 21:52:26]

Please use WindowedNotificationObserver to avoid any possible raciness.

[Scott Byer, 2011/08/27 19:28:04]

Done.  Thanks! That solved he Windows try bot issue. Don't need to fix a timing
issue by adding another one!

 }
 
 #if defined(OS_CHROMEOS)
 // Disabled until the extern URL is live so that the Print menu item
 // can be enabled for Chromium OS.
 IN_PROC_BROWSER_TEST_F(PrintDialogCloudTest, DISABLED_DialogGrabbed) {
   BrowserList::SetLastActive(browser());
   ASSERT_TRUE(BrowserList::GetLastActive());
 
   AddTestHandlers();
 
   // This goes back one step further for the Chrome OS case, to making
   // sure 'window.print()' gets to the right place.
   ASSERT_TRUE(browser()->GetSelectedTabContents());
   ASSERT_TRUE(browser()->GetSelectedTabContents()->render_view_host());
 
   string16 window_print = ASCIIToUTF16("window.print()");
   browser()->GetSelectedTabContents()->render_view_host()->
       ExecuteJavascriptInWebFrame(string16(), window_print);
 
   ui_test_utils::RunMessageLoop();
 
   ASSERT_TRUE(TestController::GetInstance()->result());
 }
 #endif