Fix flakey test by making sure WebUI dialog is shut down before test completion.

Fix flakey test by making sure WebUI dialog is shut down before test completion.

BUG=89931
TEST=Run the test on a loaded single-CPU system before and after the change.
Before, notice the dialog staying up past when the main windows goes away,
won't get through more than 1 or 2 repeats before breaking.
After, dialog goes away first, no more flakey.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98576

[Scott Byer, 2011-08-26 00:47:57]

This solves the problem by making sure the WebUI dialog is taken down before
exiting the test.

[willchan no longer on Chromium, 2011-08-26 11:47:15]

LGTM

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
File chrome/browser/printing/print_dialog_cloud_uitest.cc (right):

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
chrome/browser/printing/print_dialog_cloud_uitest.cc:240: // Close the dialog
before finishing the test.
While this will fix the test, which is a good thing, I think it begs the
question of why browser shutdown doesn't clean up all the relevant resources
cleanly. I hope there's an open bug for this.

[Paweł Hajdan Jr., 2011-08-26 21:52:26]

Drive-by with a testing comment.

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
File chrome/browser/printing/print_dialog_cloud_uitest.cc (right):

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
chrome/browser/printing/print_dialog_cloud_uitest.cc:243:
ui_test_utils::WaitForNotification(content::NOTIFICATION_TAB_CLOSED);
Please use WindowedNotificationObserver to avoid any possible raciness.

[Scott Byer, 2011-08-27 19:28:04]

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
File chrome/browser/printing/print_dialog_cloud_uitest.cc (right):

http://codereview.chromium.org/7747036/diff/1/chrome/browser/printing/print_d...
chrome/browser/printing/print_dialog_cloud_uitest.cc:243:
ui_test_utils::WaitForNotification(content::NOTIFICATION_TAB_CLOSED);
On 2011/08/26 21:52:26, Paweł Hajdan Jr. wrote:
> Please use WindowedNotificationObserver to avoid any possible raciness.

Done.  Thanks! That solved he Windows try bot issue. Don't need to fix a timing
issue by adding another one!

[commit-bot: I haz the power, 2011-08-27 23:31:59]

Try job failure for 7747036-5002 (retry) on linux for step "base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-08-28 03:23:49]

Change committed as 98576