Issue 7747014: [pyauto] GetBrowserInfo() should be usable at chromeos login screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747014: [pyauto] GetBrowserInfo() should be usable at chromeos login screen (Closed)

Created:
9 years, 4 months ago by Nirnimesh

Modified:
9 years, 4 months ago

Reviewers:
dtu

CC:
chromium-reviews, Nirnimesh, John Grabowski, kkania, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[pyauto] GetBrowserInfo() should be usable at chromeos login screen GetBrowserInfo() should not be tied to a chrome window, so that it can be used at chromeos login screen. BUG=None TEST=None R=dtu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98374

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -8 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	4 chunks	+3 lines, -5 lines	2 comments	Download
M	chrome/test/pyautolib/pyauto.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dtu

LGTM http://codereview.chromium.org/7747014/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/7747014/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode2728 chrome/browser/automation/testing_automation_provider.cc:2728: Browser* browser = *it; Huh, I'm surprised the ...

9 years, 4 months ago (2011-08-25 19:07:45 UTC) #2

Nirnimesh

9 years, 4 months ago (2011-08-25 19:16:45 UTC) #3

http://codereview.chromium.org/7747014/diff/1/chrome/browser/automation/testi...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/7747014/diff/1/chrome/browser/automation/testi...
chrome/browser/automation/testing_automation_provider.cc:2728: Browser* browser
= *it;
On 2011/08/25 19:07:45, Dave Tu wrote:
> Huh, I'm surprised the parameter was never used.

Yes. Calls into question my coding skills.

Expand Messages | Collapse Messages