[pyauto] GetBrowserInfo() should be usable at chromeos login screen

chrome/browser/automation/testing_automation_provider.cc

Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index a2fdc7301e2431e9c7a71ca599e02a0f725198a4..55021e10af6c459be5bd85c710392fe11b700999 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -2237,6 +2237,8 @@ void TestingAutomationProvider::SendJSONRequest(int handle,
       &TestingAutomationProvider::UpdateExtensionsNow;
   handler_map["CreateNewAutomationProvider"] =
       &TestingAutomationProvider::CreateNewAutomationProvider;
+  handler_map["GetBrowserInfo"] =
+      &TestingAutomationProvider::GetBrowserInfo;
 #if defined(OS_CHROMEOS)
   handler_map["GetLoginInfo"] = &TestingAutomationProvider::GetLoginInfo;
   handler_map["ShowCreateAccountUI"] =
@@ -2307,9 +2309,6 @@ void TestingAutomationProvider::SendJSONRequest(int handle,
   browser_handler_map["GetPluginsInfo"] =
       &TestingAutomationProvider::GetPluginsInfo;
 
-  browser_handler_map["GetBrowserInfo"] =
-      &TestingAutomationProvider::GetBrowserInfo;
-
   browser_handler_map["GetNavigationInfo"] =
       &TestingAutomationProvider::GetNavigationInfo;
 
@@ -2679,7 +2678,6 @@ class GetChildProcessHostInfoTask : public Task {
 // Refer to GetBrowserInfo() in chrome/test/pyautolib/pyauto.py for
 // sample json output.
 void TestingAutomationProvider::GetBrowserInfo(
-    Browser* browser,
     DictionaryValue* args,
     IPC::Message* reply_message) {
   base::ThreadRestrictions::ScopedAllowIO allow_io;  // needed for PathService
@@ -2727,7 +2725,7 @@ void TestingAutomationProvider::GetBrowserInfo(
        it != BrowserList::end();
        ++it, ++windex) {
     DictionaryValue* browser_item = new DictionaryValue;
-    browser = *it;
+    Browser* browser = *it;

[dtu, 2011/08/25 19:07:45]

Huh, I'm surprised the parameter was never used.

[Nirnimesh, 2011/08/25 19:16:45]

Yes. Calls into question my coding skills.

     browser_item->SetInteger("index", windex);
     // Window properties
     gfx::Rect rect = browser->window()->GetRestoredBounds();