Add metrics to track Autofill "user happiness"

Add metrics to track Autofill "user happiness"

BUG=none
TEST=TBD


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98397

[Ilya Sherman, 2011-08-25 03:27:31]

This CL still needs test coverage, but I wanted to run it by you in its current
state, in case there are any high-level issues you'd like to raise.

[dhollowa, 2011-08-25 21:48:15]

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_metrics.h (right):

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:88: // Loaded a page containing
(potentially autofillable) forms.
Can lose parenthetical comment.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:93: FORM_SUBMITTED_AFTER_AUTOFILL,
nix: WITHOUT and AFTER, in favor of ALL, SOME, NONE, and NON (below).

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:95: // client'stored Autofill data.
s/client'stored/stored/

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:96:
SUBMITTED_FORM_COULD_HAVE_BEEN_AUTOFILLED,
This is a "total" for three other possible happiness metrics:
(1) "ALL" autofilled,
(2) "SOME" autofilled,
(3) "NONE" autofilled

Maybe...

SUBMITTED_FILLABLE_FORM_FILLED_ALL,
SUBMITTED_FILLABLE_FORM_FILLED_SOME,
SUBMITTED_FILLABLE_FORM_FILLED_NONE

Also adding, 

SUBMITTED_NON_FILLABLE_FORM

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:103: SUGGESTIONS_SHOWN_FIRST_TIME,
s/FIRST_TIME/ONCE/

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:107: USER_DID_AUTOFILL_FIRST_TIME,
s/FIRST_TIME/ONCE/

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:109: USER_DID_EDIT_AUTOFILLED_FIELD,
It would be interesting to have ONCE and non-ONCE versions of this.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:113: // TODO(isherman): Add
histograms to measure time elapsed between form load
Comparing "fillable filled" and "fillable un-filled" would give most interesting
result.

[Ilya Sherman, 2011-08-26 00:23:30]

+Jim, in case you want to glance at the metrics changes (adding a new histogram
enumeration).

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_metrics.h (right):

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:88: // Loaded a page containing
(potentially autofillable) forms.
On 2011/08/25 21:48:15, dhollowa wrote:
> Can lose parenthetical comment.

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:93: FORM_SUBMITTED_AFTER_AUTOFILL,
On 2011/08/25 21:48:15, dhollowa wrote:
> nix: WITHOUT and AFTER, in favor of ALL, SOME, NONE, and NON (below).

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:95: // client'stored Autofill data.
On 2011/08/25 21:48:15, dhollowa wrote:
> s/client'stored/stored/

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:96:
SUBMITTED_FORM_COULD_HAVE_BEEN_AUTOFILLED,
On 2011/08/25 21:48:15, dhollowa wrote:
> This is a "total" for three other possible happiness metrics:
> (1) "ALL" autofilled,
> (2) "SOME" autofilled,
> (3) "NONE" autofilled
> 
> Maybe...
> 
> SUBMITTED_FILLABLE_FORM_FILLED_ALL,
> SUBMITTED_FILLABLE_FORM_FILLED_SOME,
> SUBMITTED_FILLABLE_FORM_FILLED_NONE
> 
> Also adding, 
> 
> SUBMITTED_NON_FILLABLE_FORM

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:103: SUGGESTIONS_SHOWN_FIRST_TIME,
On 2011/08/25 21:48:15, dhollowa wrote:
> s/FIRST_TIME/ONCE/

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:107: USER_DID_AUTOFILL_FIRST_TIME,
On 2011/08/25 21:48:15, dhollowa wrote:
> s/FIRST_TIME/ONCE/

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:109: USER_DID_EDIT_AUTOFILLED_FIELD,
On 2011/08/25 21:48:15, dhollowa wrote:
> It would be interesting to have ONCE and non-ONCE versions of this.

Done.

http://codereview.chromium.org/7747009/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics.h:113: // TODO(isherman): Add
histograms to measure time elapsed between form load
On 2011/08/25 21:48:15, dhollowa wrote:
> Comparing "fillable filled" and "fillable un-filled" would give most
interesting
> result.

Done.

[jar (doing other things), 2011-08-26 01:00:56]

The use of the HISTOGRAM macro, and naming of events LGTM.

[dhollowa, 2011-08-26 01:29:16]

LGTM.  This makes me happy.

[commit-bot: I haz the power, 2011-08-26 06:02:36]

Change committed as 98397