Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 7747009: Add metrics to track Autofill "user happiness" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index 35154c1fedf8199bc7a2d7622ee269094e43a988..d488a30acb6d0523fae1b1506e689763cb74908c 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -115,6 +115,8 @@ class AutofillManager : public TabContentsObserver,
private:
void OnFormSubmitted(const webkit_glue::FormData& form);
void OnFormsSeen(const std::vector<webkit_glue::FormData>& forms);
+ void OnTextFieldDidChange(const webkit_glue::FormData& form,
+ const webkit_glue::FormField& field);
void OnQueryFormFieldAutofill(int query_id,
const webkit_glue::FormData& form,
const webkit_glue::FormField& field);
@@ -123,8 +125,9 @@ class AutofillManager : public TabContentsObserver,
const webkit_glue::FormField& field,
int unique_id);
void OnShowAutofillDialog();
+ void OnDidPreviewAutofillFormData();
void OnDidFillAutofillFormData();
- void OnDidShowAutofillSuggestions();
+ void OnDidShowAutofillSuggestions(bool is_new_popup);
// Fills |host| with the RenderViewHost for this tab.
// Returns false if Autofill is disabled or if the host is unavailable.
@@ -217,12 +220,19 @@ class AutofillManager : public TabContentsObserver,
// For logging UMA metrics. Overridden by metrics tests.
scoped_ptr<const AutofillMetrics> metric_logger_;
-
// Have we logged whether Autofill is enabled for this page load?
bool has_logged_autofill_enabled_;
-
// Have we logged an address suggestions count metric for this page?
bool has_logged_address_suggestions_count_;
+ // Have we shown Autofill suggestions at least once?
+ bool did_show_suggestions_;
+ // Has the user manually edited at least one form field among the autofillable
+ // ones?
+ bool user_did_type_;
+ // Has the user autofilled a form on this page?
+ bool user_did_autofill_;
+ // Has the user edited a field that was previously autofilled?
+ bool user_did_edit_autofilled_field_;
// Our copy of the form data.
ScopedVector<FormStructure> form_structures_;
@@ -264,6 +274,9 @@ class AutofillManager : public TabContentsObserver,
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, QualityMetricsForFailure);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, QualityMetricsWithExperimentId);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, SaneMetricsWithCacheMismatch);
+ FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
+ UserHappinessFormLoadAndSubmission);
+ FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
DISALLOW_COPY_AND_ASSIGN(AutofillManager);
};
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698