Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

Issue 7746004: Fix crash with some keyboard shortcuts in Cocoa Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm
diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm
index e667d9c2b961e2c214d8fa8da5e7aad41e3cafcf..2e3ae97494c8c10fb719713455b91a36d66e5b64 100644
--- a/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm
+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm
@@ -4,7 +4,7 @@
#import "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
-#import <Cocoa/Cocoa.h>
+#include <Carbon/Carbon.h>
Dmitry Titov 2011/08/24 23:27:46 Why this change? Don't you now rely on one of the
jennb 2011/08/24 23:29:30 kVK_Tab was not defined until I made this change.
#include "base/command_line.h"
#include "base/debug/debugger.h"
@@ -14,6 +14,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#import "chrome/browser/ui/cocoa/browser_test_helper.h"
+#import "chrome/browser/ui/cocoa/browser_window_utils.h"
#import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#include "chrome/browser/ui/panels/panel.h"
#include "chrome/browser/ui/panels/panel_manager.h"
@@ -308,3 +309,22 @@ TEST_F(PanelBrowserWindowCocoaTest, MenuItems) {
ClosePanelAndWait(panel->browser());
}
+
+TEST_F(PanelBrowserWindowCocoaTest, KeyEvent) {
+ Panel* panel = CreateTestPanel("Test Panel");
+ NSEvent* event = [NSEvent keyEventWithType:NSKeyDown
+ location:NSZeroPoint
+ modifierFlags:NSControlKeyMask
+ timestamp:0.0
+ windowNumber:0
+ context:nil
+ characters:@""
+ charactersIgnoringModifiers:@""
+ isARepeat:NO
+ keyCode:kVK_Tab];
+ PanelBrowserWindowCocoa* native_window =
+ static_cast<PanelBrowserWindowCocoa*>(panel->native_panel());
+ [BrowserWindowUtils handleKeyboardEvent:event
+ inWindow:[native_window->controller_ window]];
+ ClosePanelAndWait(panel->browser());
+}
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_cocoa.h ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698