Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Unified Diff: base/values_unittest.cc

Issue 7745040: [Sync] Make P2PNotifier behave more like InvalidationNotifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 0ca19d9d2b626b96b4ffb0f9f83008590c7ef430..67dccaae3a8f7ce935697f7c823a3775b623e1d4 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -93,6 +93,12 @@ TEST(ValuesTest, List) {
ASSERT_EQ(88.8, double_value);
ASSERT_TRUE(mixed_list->GetString(3, &string_value));
ASSERT_EQ("foo", string_value);
+
+ {
+ ListValue* list_value = NULL;
+ ASSERT_TRUE(mixed_list->GetAsList(&list_value));
+ ASSERT_EQ(mixed_list.get(), list_value);
+ }
}
TEST(ValuesTest, BinaryValue) {
@@ -244,6 +250,15 @@ TEST(ValuesTest, ListRemoval) {
}
}
+TEST(ValuesTest, DictionaryBasic) {
+ DictionaryValue dict;
+ {
+ DictionaryValue* dict_value = NULL;
+ ASSERT_TRUE(dict.GetAsDictionary(&dict_value));
+ ASSERT_EQ(&dict, dict_value);
+ }
+}
+
TEST(ValuesTest, DictionaryDeletion) {
std::string key = "test";
bool deletion_flag = true;

Powered by Google App Engine
This is Rietveld 408576698