[Sync] Make P2PNotifier behave more like InvalidationNotifier

base/values.h

Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 185729d087de5052c3006ead38acb6a24b8fd530..ed68448674b811c79ea4d14a865ce9b90a2fe755 100644
--- a/base/values.h
+++ b/base/values.h
@@ -101,6 +101,8 @@ class BASE_EXPORT Value {
   virtual bool GetAsString(string16* out_value) const;
   virtual bool GetAsList(ListValue** out_value);
   virtual bool GetAsList(const ListValue** out_value) const;
+  virtual bool GetAsDictionary(DictionaryValue** out_value);
+  virtual bool GetAsDictionary(const DictionaryValue** out_value) const;

[Evan Martin, 2011/08/26 18:46:33]

I think we're trying to move to a different API, like:

virtual DictionaryValue* AsDictionary() const;
which returns NULL for non-dictionaries.

[akalin, 2011/08/26 18:56:43]

Okay.  It seems kinda weird to have a mixture of old/new APIs, though.  I'd
rather have it be consistent and them all be changed at once.

[tfarina, 2011/08/26 18:59:06]

Don't need to add AsDictionary in this patch. The others As* functions were
reverted by Steven already.

 
   // This creates a deep copy of the entire Value tree, and returns a pointer
   // to the copy.  The caller gets ownership of the copy, of course.
@@ -347,6 +349,9 @@ class BASE_EXPORT DictionaryValue : public Value {
   key_iterator end_keys() const { return key_iterator(dictionary_.end()); }
 
   // Overridden from Value:
+  virtual bool GetAsDictionary(DictionaryValue** out_value) OVERRIDE;
+  virtual bool GetAsDictionary(
+      const DictionaryValue** out_value) const OVERRIDE;
   virtual DictionaryValue* DeepCopy() const OVERRIDE;
   virtual bool Equals(const Value* other) const OVERRIDE;