Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7745018: Always enable roaming for cellular operators that don't work without it (Closed)

Created:
9 years, 4 months ago by Dmitry Polukhin
Modified:
9 years, 4 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Always enable roaming for cellular operators that don't work without it BUG=chrome-os-partner:5370 TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98227

Patch Set 1 #

Patch Set 2 : tests fixed #

Total comments: 3

Patch Set 3 : comments resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -15 lines) Patch
M chrome/browser/chromeos/cros/mock_network_library.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 2 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 2 7 chunks +46 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/user_cros_settings_provider.cc View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Polukhin
9 years, 4 months ago (2011-08-25 10:08:44 UTC) #1
Nikita (slow)
http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc#newcode3498 chrome/browser/chromeos/cros/network_library.cc:3498: const std::string& home_provider = cellular->home_provider(); home_provider_name() network.home_provider_ is not ...
9 years, 4 months ago (2011-08-25 11:32:46 UTC) #2
Nikita (slow)
http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc#newcode3499 chrome/browser/chromeos/cros/network_library.cc:3499: for (size_t i = 0; i < arraysize(kAlwaysInRoamingOperators); i++) ...
9 years, 4 months ago (2011-08-25 11:59:17 UTC) #3
Dmitry Polukhin
http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/7745018/diff/3001/chrome/browser/chromeos/cros/network_library.cc#newcode3498 chrome/browser/chromeos/cros/network_library.cc:3498: const std::string& home_provider = cellular->home_provider(); On 2011/08/25 11:32:46, Nikita ...
9 years, 4 months ago (2011-08-25 12:39:27 UTC) #4
Nikita (slow)
9 years, 4 months ago (2011-08-25 13:57:13 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698