Always enable roaming for cellular operators that don't work without it

chrome/browser/chromeos/user_cros_settings_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/user_cros_settings_provider.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 290 matching lines @@
     }
   }
 
   // Called right before boolean property is changed.
   void OnBooleanPropertyChange(const std::string& path, bool new_value) {
     if (path == kSignedDataRoamingEnabled) {
       if (!CrosLibrary::Get()->EnsureLoaded())
         return;
 
       NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
+      if (cros->IsCellularAlwaysInRoaming()) {
+        // If operator requires roaming always enabled, ignore supplied value
+        // and set data roaming allowed in true always.
+        new_value = true;
+      }
       cros->SetCellularDataRoamingAllowed(new_value);
     } else if (path == kStatsReportingPref) {
       // TODO(pastarmovj): Remove this once we don't need to regenerate the
       // consent file for the GUID anymore.
       OptionsUtil::ResolveMetricsReportingEnabled(new_value);
     }
   }
 
   // Called right after signed value was checked.
   void OnBooleanPropertyRetrieve(const std::string& path,
                                  bool value,
                                  UseValue use_value) {
     if (path == kSignedDataRoamingEnabled) {
       if (!CrosLibrary::Get()->EnsureLoaded())
         return;
 
       NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
       const NetworkDevice* cellular = cros->FindCellularDevice();
       if (cellular) {
         bool device_value = cellular->data_roaming_allowed();
-        bool new_value = (use_value == USE_VALUE_SUPPLIED) ? value : false;
-        if (device_value != new_value)
-          cros->SetCellularDataRoamingAllowed(new_value);
+        if (!device_value && cros->IsCellularAlwaysInRoaming()) {
+          // If operator requires roaming always enabled, ignore supplied value
+          // and set data roaming allowed in true always.
+          cros->SetCellularDataRoamingAllowed(true);
+        } else {
+          bool new_value = (use_value == USE_VALUE_SUPPLIED) ? value : false;
+          if (device_value != new_value)
+            cros->SetCellularDataRoamingAllowed(new_value);
+        }
       }
     } else if (path == kStatsReportingPref) {
       bool stats_consent = (use_value == USE_VALUE_SUPPLIED) ? value : false;
       // TODO(pastarmovj): Remove this once migration is not needed anymore.
       // If the value is not set we should try to migrate legacy consent file.
       if (use_value == USE_VALUE_DEFAULT) {
         // Loading consent file state causes us to do blocking IO on UI thread.
         // Temporarily allow it until we fix http://crbug.com/62626
         base::ThreadRestrictions::ScopedAllowIO allow_io;
         stats_consent = GoogleUpdateSettings::GetCollectStatsConsent();
@@ skipping 343 matching lines @@
   if (cached_whitelist_update->Remove(email_value, NULL))
     prefs->ScheduleSavePersistentPrefs();
 }
 
 // static
 void UserCrosSettingsProvider::UpdateCachedOwner(const std::string& email) {
   UpdateCacheString(kDeviceOwner, email, USE_VALUE_SUPPLIED);
 }
 
 }  // namespace chromeos