To fix the failing password test: passwords.PasswordTest.testDisplayAndSavePasswordInfobar

To fix the failing password test: passwords.PasswordTest.testDisplayAndSavePasswordInfobar

BUG=91222
Test=passwords.PasswordTest.testDisplayAndSavePasswordInfobar

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99119

[Venkat Yellapu, 2011-08-25 20:44:10]

To fix the failing pyauto test:
passwords.PasswordTest.testDisplayAndSavePasswordInfobar.
We need to wait until the username/password is filled by the Password manager on
the login page.

[Nirnimesh, 2011-08-28 07:15:16]

Doesn't look like this is ready for review. I see leftover raw_input() and
commented out code. Have you run it before sending for review?

http://codereview.chromium.org/7744035/diff/3001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/7744035/diff/3001/functional/PYAUTO_TESTS#oldc...
functional/PYAUTO_TESTS:362:
'-passwords.PasswordTest.testDisplayAndSavePasswordInfobar',
Do not remove from this list - CONTINUOUS_PUBLIC. This is a list of tests that
can run publicly. Tests that depend on private data (passwords file in this
case) cannot be included in this suite.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:106: self.WaitUntil(
wrap inside assertTrue

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:184: raw_input()
??

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:186: raw_input()
??

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:191: raw_input()
??

Please run the tests before submitting for review. This test has clearly not
been run.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:258: test_utils.GoogleAccountsLogin(self,
user_creds['username'], user_creds['password'])
80+ chars not allowed

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:261: raw_input()
??

[Venkat Yellapu, 2011-08-30 00:03:03]

My bad, that is really ugly. Minutes before submitting the original CL, I just
demonstrated what is the issue with other failing pyauto
test:testClearFetchedCredForNewUserName and what's the solution to fix it to
Anantha. I totally forgot to 'undo' those temporary updates, before submitting
the original CL, that caused all these mess up. Please note I'm going to send
separate CL for other failing pyauto test testClearFetchedCredForNewUserName. I
do run the specific test few times before the submission, but I should have ran
all the tests in passwords that might have caught my temp updates :(.
Thanks Nirnimesh for finding them :).

http://codereview.chromium.org/7744035/diff/3001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/7744035/diff/3001/functional/PYAUTO_TESTS#oldc...
functional/PYAUTO_TESTS:362:
'-passwords.PasswordTest.testDisplayAndSavePasswordInfobar',
On 2011/08/28 07:15:16, Nirnimesh wrote:
> Do not remove from this list - CONTINUOUS_PUBLIC. This is a list of tests that
> can run publicly. Tests that depend on private data (passwords file in this
> case) cannot be included in this suite.

Done.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:106: self.WaitUntil(
On 2011/08/28 07:15:16, Nirnimesh wrote:
> wrap inside assertTrue

Done.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:184: raw_input()
On 2011/08/28 07:15:16, Nirnimesh wrote:
> ??

Done.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:186: raw_input()
On 2011/08/28 07:15:16, Nirnimesh wrote:
> ??

Done.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:191: raw_input()
On 2011/08/28 07:15:16, Nirnimesh wrote:
> ??
> 
> Please run the tests before submitting for review. This test has clearly not
> been run.

Done.

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:258: test_utils.GoogleAccountsLogin(self,
user_creds['username'], user_creds['password'])
I'm not going to change this function in this CL. I'll send a separate CL to fix
this test. For more info, pls see the description.
On 2011/08/28 07:15:16, Nirnimesh wrote:
> 80+ chars not allowed

http://codereview.chromium.org/7744035/diff/3001/functional/passwords.py#newc...
functional/passwords.py:261: raw_input()
On 2011/08/28 07:15:16, Nirnimesh wrote:
> ??

Done.

[Nirnimesh, 2011-08-31 08:16:41]

LGTM, with one nit.

http://codereview.chromium.org/7744035/diff/9001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/7744035/diff/9001/functional/passwords.py#newc...
functional/passwords.py:108: 0, 0) != ""))
use '

[Venkat Yellapu, 2011-09-01 00:32:56]

Done. Submitting the CL.

Thanks,
Venkat.

http://codereview.chromium.org/7744035/diff/9001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/7744035/diff/9001/functional/passwords.py#newc...
functional/passwords.py:108: 0, 0) != ""))
On 2011/08/31 08:16:41, Nirnimesh wrote:
> use '

Done.

[commit-bot: I haz the power, 2011-09-01 03:51:49]

Change committed as 99119