To fix the failing password test: passwords.PasswordTest.testDisplayAndSavePasswordInfobar

functional/passwords.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 import test_utils
@@ skipping 84 matching lines @@
     self.WaitUntil(
         lambda: self.GetDOMValue('document.readyState'),
         expect_retval='complete')
     self.assertTrue(self.WaitForInfobarCount(1),
                     'Save password infobar did not appear.')
     infobar = self.GetBrowserInfo()['windows'][0]['tabs'][0]['infobars']
     self.assertEqual(infobar[0]['type'], 'confirm_infobar')
     self.PerformActionOnInfobar('accept', infobar_index=0)
     self.NavigateToURL(url_logout)
     self.AppendTab(pyauto.GURL(url_https))  # New tab to avoid bug 70694
-    # Wait until accounts page load to detect value in username field.
-    self.WaitUntil(lambda: self.GetDOMValue('document.readyState', 0, 1),
-                   expect_retval='complete')
+    # Wait until username is filled by the Password manager on the login page.
+    self.WaitUntil(

[Nirnimesh, 2011/08/28 07:15:16]

wrap inside assertTrue

[Venkat Yellapu, 2011/08/30 00:03:03]

Done.

+        lambda: self.GetDOMValue('document.getElementById("Email").value',
+                                 0, 0) != "")
     test_utils.VerifyGoogleAccountCredsFilled(self, username, password,
                                               tab_index=1, windex=0)
     self.ExecuteJavascript('document.getElementById("gaia_loginform").submit();'
                            'window.domAutomationController.send("done")',
                            0, 1)
     test_utils.ClearPasswords(self)
 
   def testNeverSavePasswords(self):
     """Verify passwords not saved/deleted when 'never for this site' chosen."""
     creds1 = self.GetPrivateInfo()['test_google_account']
@@ skipping 55 matching lines @@
     self.NavigateToURL('chrome://history')
     self.assertTrue(self.WaitForInfobarCount(0))
     # To make sure user is navigated to History page.
     self.assertEqual('History', self.GetActiveTabTitle())
     self.assertFalse(self.GetBrowserInfo()['windows'][0]['tabs'][0]['infobars'])
 
   def testInfoBarDisappearByReload(self):
     """Test that Password infobar disappears by the page reload."""
     creds = self.GetPrivateInfo()['test_google_account']
     # Login to Google a/c
+    raw_input()

[Nirnimesh, 2011/08/28 07:15:16]

??

[Venkat Yellapu, 2011/08/30 00:03:03]

Done.

     test_utils.GoogleAccountsLogin(self, creds['username'], creds['password'])
+    raw_input()

[Nirnimesh, 2011/08/28 07:15:16]

??

[Venkat Yellapu, 2011/08/30 00:03:03]

Done.

     # Wait for the infobar to appear
     self.assertTrue(self.WaitForInfobarCount(1))
     self.assertTrue(self.GetBrowserInfo()['windows'][0]['tabs'][0]['infobars'])
     self.GetBrowserWindow(0).GetTab(0).Reload()
+    raw_input()

[Nirnimesh, 2011/08/28 07:15:16]

??

Please run the tests before submitting for review. This test has clearly not
been run.

[Venkat Yellapu, 2011/08/30 00:03:03]

Done.

     self.assertTrue(self.WaitForInfobarCount(0))
     self.assertFalse(self.GetBrowserInfo()['windows'][0]['tabs'][0]['infobars'])
 
   def testPasswdInfoNotStoredWhenAutocompleteOff(self):
     """Verify that password infobar does not appear when autocomplete is off.
 
     If the password field has autocomplete turned off, then the password infobar
     should not offer to save the password info.
     """
     password_info = {'Email': 'test@google.com',
@@ skipping 45 matching lines @@
     into the Email field.
     """
     user_creds = self._ConstructPasswordDictionary(
         'user1@example.com', 'test1.password',
         'https://www.google.com/',
         'https://www.google.com/accounts/ServiceLogin',
         'username', 'password',
         'https://www.google.com/accounts/ServiceLogin')
 
     url = 'https://www.google.com/accounts/ServiceLogin'
-    self.AddSavedPassword(user_creds)
-    self.NavigateToURL(url)
+    user_creds = self.GetPrivateInfo()['test_google_account']
+    test_utils.GoogleAccountsLogin(self, user_creds['username'], user_creds['password'])

[Nirnimesh, 2011/08/28 07:15:16]

80+ chars not allowed

[Venkat Yellapu, 2011/08/30 00:03:03]

I'm not going to change this function in this CL. I'll send a separate CL to fix
this test. For more info, pls see the description.
On 2011/08/28 07:15:16, Nirnimesh wrote:

+
+    #self.AddSavedPassword(user_creds)
+    raw_input()

[Nirnimesh, 2011/08/28 07:15:16]

??

[Venkat Yellapu, 2011/08/30 00:03:03]

Done.

+    #self.NavigateToURL(url)
+    #raw_input()
     self.WaitUntil(
         lambda: self.GetDOMValue('document.readyState'),
         expect_retval='complete')
     test_utils.VerifyGoogleAccountCredsFilled(
         self, user_creds['username_value'], user_creds['password_value'],
         tab_index=0, windex=0)
     clear_username_field = (
         'document.getElementById("Email").value = ""; '
         'window.domAutomationController.send("done");')
     set_focus = (
         'document.getElementById("Email").focus(); '
         'window.domAutomationController.send("done");')
     self.ExecuteJavascript(clear_username_field, 0, 0)
     self.ExecuteJavascript(set_focus, 0, 0)
     self._SendCharToPopulateField('t', tab_index=0, windex=0)
     passwd_value = self.GetDOMValue('document.getElementById("Passwd").value')
     self.assertFalse(passwd_value,
                      msg='Password field not empty for new username.')
     test_utils.ClearPasswords(self)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()