Issue 7741027: Create a new views_aura_desktop.

Issue 7741027: Create a new views_aura_desktop. (Closed)

Created:
9 years, 4 months ago by Ben Goodger (Google)

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Create a new views_aura_desktop. Get views::Widget rendering working against an aura::Window NativeWidget. http://crbug.com/93944 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98306

Patch Set 3 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+540 lines, -79 lines)			Patch
M	aura/demo/demo_main.cc	View		3 chunks	+20 lines, -42 lines	0 comments	Download
M	aura/desktop.h	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	aura/desktop.cc	View		2 chunks	+26 lines, -3 lines	0 comments	Download
M	aura/window.h	View		4 chunks	+10 lines, -4 lines	0 comments	Download
M	aura/window.cc	View	1	4 chunks	+22 lines, -8 lines	0 comments	Download
M	aura/window_delegate.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	ui/gfx/screen_aura.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	views/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	views/aura_desktop/aura_desktop_main.cc	View		1 chunk	+106 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
A	views/focus/accelerator_handler_aura.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	views/view_aura.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		4 chunks	+51 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_aura.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	views/widget/native_widget_aura.cc	View		4 chunks	+165 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/7741027/diff/3005/aura/window.cc File aura/window.cc (right): http://codereview.chromium.org/7741027/diff/3005/aura/window.cc#newcode63 aura/window.cc:63: if (parent) Should this change the parent of the ...

9 years, 4 months ago (2011-08-25 20:48:46 UTC) #2

Ben Goodger (Google)

Updated with translate. http://codereview.chromium.org/7741027/diff/3005/aura/window.cc File aura/window.cc (right): http://codereview.chromium.org/7741027/diff/3005/aura/window.cc#newcode63 aura/window.cc:63: if (parent) On 2011/08/25 20:48:46, sky ...

9 years, 4 months ago (2011-08-25 21:08:00 UTC) #3

LGTM

Expand Messages | Collapse Messages