Issue 7741006: Get rid of all chrome includes from RenderWidgetHostViewWin. We'll want to move this to content s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7741006: Get rid of all chrome includes from RenderWidgetHostViewWin. We'll want to move this to content s... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Get rid of all chrome includes from RenderWidgetHostViewWin. We'll want to move this to content so that the content browser can reuse all this code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98240

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -18 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views_win.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	3 chunks	+4 lines, -18 lines	0 comments	Download
M	content/browser/content_browser_client.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

jam

This was surprisingly painless. I'll talk to you tomorrow about what to do with the ...

9 years, 4 months ago (2011-08-25 01:42:59 UTC) #1

LGTM