Add metrics to measure time elapsed between form load and form submission with or without Autofill.

chrome/common/autofill_messages.h

Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index 75cc2fb52bf5fa8d4bd02c0dcfb4b4d2588dadd7..213f081d8f63e8720a597460235e7c75d8fd3848 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -6,8 +6,10 @@
 
 #include <string>
 
+#include "base/time.h"
 #include "content/common/webkit_param_traits.h"
 #include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_message_utils.h"
 #include "webkit/glue/form_data.h"
 #include "webkit/glue/form_data_predictions.h"
 #include "webkit/glue/form_field.h"
@@ -90,8 +92,9 @@ IPC_MESSAGE_ROUTED1(
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_FormsSeen,
-                    std::vector<webkit_glue::FormData> /* forms */)
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormsSeen,
+                    std::vector<webkit_glue::FormData> /* forms */,
+                    base::TimeTicks /* timestamp */)

[jar (doing other things), 2011/09/02 01:48:33]

I didn't watch the flow carefully... but be certain to only compare TimeTicks
values obtained in the the same process.  Each process has a different baseline,
so times in different processes are not comparable.

If this is a problem, you can normalize them during transit by changing them to
a TimeDelta at this boundary (and optionally translating them back to a
TimeTicks in the other process).

[Ilya Sherman, 2011/09/02 06:57:54]

Yes, all of the TimeTicks values are being collected in the renderer process,
which is where the user interaction occurs.  Thanks for the warning though!  :)

 
 // Notification that password forms have been seen that are candidates for
 // filling/submitting by the password manager.
@@ -104,13 +107,15 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsVisible,
                     std::vector<webkit_glue::PasswordForm> /* forms */)
 
 // Notification that a form has been submitted.  The user hit the button.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_FormSubmitted,
-                    webkit_glue::FormData /* form */)
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormSubmitted,
+                    webkit_glue::FormData /* form */,
+                    base::TimeTicks /* timestamp */)
 
 // Notification that a form field's value has changed.
-IPC_MESSAGE_ROUTED2(AutofillHostMsg_TextFieldDidChange,
+IPC_MESSAGE_ROUTED3(AutofillHostMsg_TextFieldDidChange,
                     webkit_glue::FormData /* the form */,
-                    webkit_glue::FormField /* the form field */)
+                    webkit_glue::FormField /* the form field */,
+                    base::TimeTicks /* timestamp */)
 
 // Queries the browser for Autofill suggestions for a form input field.
 IPC_MESSAGE_ROUTED3(AutofillHostMsg_QueryFormFieldAutofill,
@@ -134,7 +139,8 @@ IPC_MESSAGE_ROUTED4(AutofillHostMsg_FillAutofillFormData,
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
 
 // Sent when a form is filled with Autofill suggestions.
-IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidFillAutofillFormData)
+IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,
+                    base::TimeTicks /* timestamp */)
 
 // Instructs the browser to remove the specified Autocomplete entry from the
 // database.