Add metrics to measure time elapsed between form load and form submission with or without Autofill.

chrome/common/autofill_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
+#include "base/time.h"
 #include "content/common/webkit_param_traits.h"
 #include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_message_utils.h"
 #include "webkit/glue/form_data.h"
 #include "webkit/glue/form_data_predictions.h"
 #include "webkit/glue/form_field.h"
 #include "webkit/glue/form_field_predictions.h"
 #include "webkit/glue/password_form.h"
 #include "webkit/glue/password_form_dom_manager.h"
 
 #define IPC_MESSAGE_START AutofillMsgStart
 
 IPC_STRUCT_TRAITS_BEGIN(webkit_glue::FormField)
@@ skipping 62 matching lines @@
 
 // Send the heuristic and server field type predictions to the renderer.
 IPC_MESSAGE_ROUTED1(
     AutofillMsg_FieldTypePredictionsAvailable,
     std::vector<webkit_glue::FormDataPredictions> /* forms */)
 
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_FormsSeen,
-                    std::vector<webkit_glue::FormData> /* forms */)
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormsSeen,
+                    std::vector<webkit_glue::FormData> /* forms */,
+                    base::TimeTicks /* timestamp */)

[jar (doing other things), 2011/09/02 01:48:33]

I didn't watch the flow carefully... but be certain to only compare TimeTicks
values obtained in the the same process.  Each process has a different baseline,
so times in different processes are not comparable.

If this is a problem, you can normalize them during transit by changing them to
a TimeDelta at this boundary (and optionally translating them back to a
TimeTicks in the other process).

[Ilya Sherman, 2011/09/02 06:57:54]

Yes, all of the TimeTicks values are being collected in the renderer process,
which is where the user interaction occurs.  Thanks for the warning though!  :)

 
 // Notification that password forms have been seen that are candidates for
 // filling/submitting by the password manager.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsFound,
                     std::vector<webkit_glue::PasswordForm> /* forms */)
 
 // Notification that initial layout has occurred and the following password
 // forms are visible on the page (e.g. not set to display:none.)
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsVisible,
                     std::vector<webkit_glue::PasswordForm> /* forms */)
 
 // Notification that a form has been submitted.  The user hit the button.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_FormSubmitted,
-                    webkit_glue::FormData /* form */)
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormSubmitted,
+                    webkit_glue::FormData /* form */,
+                    base::TimeTicks /* timestamp */)
 
 // Notification that a form field's value has changed.
-IPC_MESSAGE_ROUTED2(AutofillHostMsg_TextFieldDidChange,
+IPC_MESSAGE_ROUTED3(AutofillHostMsg_TextFieldDidChange,
                     webkit_glue::FormData /* the form */,
-                    webkit_glue::FormField /* the form field */)
+                    webkit_glue::FormField /* the form field */,
+                    base::TimeTicks /* timestamp */)
 
 // Queries the browser for Autofill suggestions for a form input field.
 IPC_MESSAGE_ROUTED3(AutofillHostMsg_QueryFormFieldAutofill,
                     int /* id of this message */,
                     webkit_glue::FormData /* the form */,
                     webkit_glue::FormField /* the form field */)
 
 // Sent when the popup with Autofill suggestions for a form is shown.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidShowAutofillSuggestions,
                     bool /* is this a new popup? */)
 
 // Instructs the browser to fill in the values for a form using Autofill
 // profile data.
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_FillAutofillFormData,
                     int /* id of this message */,
                     webkit_glue::FormData /* the form  */,
                     webkit_glue::FormField /* the form field  */,
                     int /* profile unique ID */)
 
 // Sent when a form is previewed with Autofill suggestions.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
 
 // Sent when a form is filled with Autofill suggestions.
-IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidFillAutofillFormData)
+IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,
+                    base::TimeTicks /* timestamp */)
 
 // Instructs the browser to remove the specified Autocomplete entry from the
 // database.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemoveAutocompleteEntry,
                     string16 /* field name */,
                     string16 /* value */)
 
 // Instructs the browser to show the Autofill dialog.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_ShowAutofillDialog)