Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: chrome/browser/autofill/autofill_metrics.cc

Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_metrics.cc
diff --git a/chrome/browser/autofill/autofill_metrics.cc b/chrome/browser/autofill/autofill_metrics.cc
index c3ad14927d3f8fa9b1d597e4e08a1f2218ec6996..2a7424b384a34cb942887c0973b9d0240133295c 100644
--- a/chrome/browser/autofill/autofill_metrics.cc
+++ b/chrome/browser/autofill/autofill_metrics.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/metrics/histogram.h"
+#include "base/time.h"
#include "chrome/browser/autofill/autofill_type.h"
#include "chrome/browser/autofill/form_structure.h"
#include "webkit/glue/form_data.h"
@@ -298,6 +299,29 @@ void AutofillMetrics::LogUserHappinessMetric(UserHappinessMetric metric) const {
NUM_USER_HAPPINESS_METRICS);
}
+void AutofillMetrics::LogFormFillDurationFromLoadWithAutofill(
+ const base::TimeDelta& duration) const {
+ UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromLoad.WithAutofill", duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromLoadWithoutAutofill(
+ const base::TimeDelta& duration) const {
+ UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromLoad.WithoutAutofill",
+ duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromInteractionWithAutofill(
+ const base::TimeDelta& duration) const {
+ UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromInteraction.WithAutofill",
jar (doing other things) 2011/09/02 01:48:33 What is the dynamic range you're expecting for thi
Ilya Sherman 2011/09/02 06:57:54 Oh, wow, good catch! I think 100ms to 10 minutes
jar (doing other things) 2011/09/02 20:09:26 Your change to 100ms through 10 minutes looks grea
+ duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromInteractionWithoutAutofill(
+ const base::TimeDelta& duration) const {
+ UMA_HISTOGRAM_TIMES("Autofill.FormFillTime.FromInteraction.WithoutAutofill",
+ duration);
+}
+
void AutofillMetrics::LogIsAutofillEnabledAtStartup(bool enabled) const {
UMA_HISTOGRAM_BOOLEAN("Autofill.IsEnabled.Startup", enabled);
}

Powered by Google App Engine
This is Rietveld 408576698