Add metrics to measure time elapsed between form load and form submission with or without Autofill.

chrome/browser/autofill/autofill_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_metrics.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
+#include "base/time.h"
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "webkit/glue/form_data.h"
 
 namespace {
 
 // Server experiments we support.
 enum ServerExperiment {
   NO_EXPERIMENT = 0,
   UNKNOWN_EXPERIMENT,
@@ skipping 272 matching lines @@
                             NUM_SERVER_QUERY_METRICS);
 }
 
 void AutofillMetrics::LogUserHappinessMetric(UserHappinessMetric metric) const {
   DCHECK(metric < NUM_USER_HAPPINESS_METRICS);
 
   UMA_HISTOGRAM_ENUMERATION("Autofill.UserHappiness", metric,
                             NUM_USER_HAPPINESS_METRICS);
 }
 
+void AutofillMetrics::LogFormFillDurationFromLoadWithAutofill(
+    const base::TimeDelta& duration) const {
+  UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromLoad.WithAutofill", duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromLoadWithoutAutofill(
+    const base::TimeDelta& duration) const {
+  UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromLoad.WithoutAutofill",
+                      duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromInteractionWithAutofill(
+    const base::TimeDelta& duration) const {
+  UMA_HISTOGRAM_TIMES("Autofill.FillDuration.FromInteraction.WithAutofill",

[jar (doing other things), 2011/09/02 01:48:33]

What is the dynamic range you're expecting for this?  UMA_HISTOGRAM_TIMES has
its overflow bucket start at 10seconds.  Is that too short?  
For instance, UMA_HISTOGRAM_MEDIUM_TIME() runs from 10ms to 3 minutes (and
you'll hopefully make very little use of that tail).

[Ilya Sherman, 2011/09/02 06:57:54]

Oh, wow, good catch!  I think 100ms to 10 minutes is probably a reasonable
dynamic range for this metric -- does my change look correct for that?

[jar (doing other things), 2011/09/02 20:09:26]

Your change to 100ms through 10 minutes looks great.  Thanks.

+                      duration);
+}
+
+void AutofillMetrics::LogFormFillDurationFromInteractionWithoutAutofill(
+    const base::TimeDelta& duration) const {
+  UMA_HISTOGRAM_TIMES("Autofill.FormFillTime.FromInteraction.WithoutAutofill",
+                      duration);
+}
+
 void AutofillMetrics::LogIsAutofillEnabledAtStartup(bool enabled) const {
   UMA_HISTOGRAM_BOOLEAN("Autofill.IsEnabled.Startup", enabled);
 }
 
 void AutofillMetrics::LogIsAutofillEnabledAtPageLoad(bool enabled) const {
   UMA_HISTOGRAM_BOOLEAN("Autofill.IsEnabled.PageLoad", enabled);
 }
 
 void AutofillMetrics::LogStoredProfileCount(size_t num_profiles) const {
   UMA_HISTOGRAM_COUNTS("Autofill.StoredProfileCount", num_profiles);
 }
 
 void AutofillMetrics::LogAddressSuggestionsCount(size_t num_suggestions) const {
   UMA_HISTOGRAM_COUNTS("Autofill.AddressSuggestionsCount", num_suggestions);
 }
 
 void AutofillMetrics::LogServerExperimentIdForQuery(
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Query", experiment_id);
 }
 
 void AutofillMetrics::LogServerExperimentIdForUpload(
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Upload", experiment_id);
 }