Issue 7740056: Revert 98767 - Reimplement the Pepper fullscreen API to use webkitRequestFullScreen and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7740056: Revert 98767 - Reimplement the Pepper fullscreen API to use webkitRequestFullScreen and friends. (Closed)

Created:
9 years, 3 months ago by piman

Modified:
9 years, 3 months ago

Reviewers:
brettw, koz (OOO until 15th September)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, jeremya

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 98767 - Reimplement the Pepper fullscreen API to use webkitRequestFullScreen and friends. This depends on https://bugs.webkit.org/show_bug.cgi?id=66746 and http://codereview.chromium.org/7461059/, neither of which have been landed. So this should be considered a preliminary review at this stage :) BUG= TEST= Review URL: http://codereview.chromium.org/7714017 TBR=koz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98896

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -32 lines)			Patch
MM	content/renderer/pepper_plugin_delegate_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	content/renderer/pepper_plugin_delegate_impl.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	13 chunks	+72 lines, -25 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_webplugin_impl.cc	View	3 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

piman

The new implementation isn't functional on linux, so it regresses Flash severely on Chrome OS.

9 years, 3 months ago (2011-08-30 20:04:13 UTC) #2

koz (OOO until 15th September)

9 years, 3 months ago (2011-08-30 20:59:51 UTC) #3

On 2011/08/30 20:04:13, piman wrote:
> The new implementation isn't functional on linux, so it regresses Flash
severely
> on Chrome OS.

LGTM.