Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 7740056: Revert 98767 - Reimplement the Pepper fullscreen API to use webkitRequestFullScreen and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/plugin_delegate.h ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
===================================================================
--- webkit/plugins/ppapi/ppapi_plugin_instance.h (revision 98865)
+++ webkit/plugins/ppapi/ppapi_plugin_instance.h (working copy)
@@ -64,6 +64,7 @@
namespace webkit {
namespace ppapi {
+class FullscreenContainer;
class MessageChannel;
class ObjectVar;
class PluginDelegate;
@@ -241,6 +242,10 @@
// embedded in a page).
bool IsFullPagePlugin() const;
+ FullscreenContainer* fullscreen_container() const {
+ return fullscreen_container_;
+ }
+
// FunctionGroupBase overrides.
virtual ::ppapi::thunk::PPB_Instance_FunctionAPI* AsPPB_Instance_FunctionAPI()
OVERRIDE;
@@ -431,11 +436,10 @@
// to use a more optimized painting path in some cases.
bool always_on_top_;
- // Since entering fullscreen mode is an asynchronous operation, we set this
- // variable to the desired state at the time we issue the fullscreen change
- // request. The plugin will receive a DidChangeView event when it goes
- // fullscreen.
- bool desired_fullscreen_state_;
+ // Plugin container for fullscreen mode. NULL if not in fullscreen mode. Note:
+ // there is a transition state where fullscreen_container_ is non-NULL but
+ // fullscreen_ is false (see above).
+ FullscreenContainer* fullscreen_container_;
// True if we are in fullscreen mode. Note: it is false during the transition.
bool fullscreen_;
« no previous file with comments | « webkit/plugins/ppapi/plugin_delegate.h ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698