Set user-visible machine names and devices types for synced sessions.

chrome/browser/sessions/session_types.h

Index: chrome/browser/sessions/session_types.h
diff --git a/chrome/browser/sessions/session_types.h b/chrome/browser/sessions/session_types.h
index fd52cb99f0936b382de58df7f380be07c5a3c646..80d581488ee9d4c0e04343c5a6ce843ff4529421 100644
--- a/chrome/browser/sessions/session_types.h
+++ b/chrome/browser/sessions/session_types.h
@@ -205,6 +205,17 @@ struct SyncedSession {
 
   // Unique tag for each session.
   std::string session_tag;
+  // User-visible name
+  std::string client_name;
+  // The type of device.
+  enum DeviceType {

[sky, 2011/08/31 03:35:16]

enum before constructor.

[Yaron, 2011/08/31 23:23:22]

Done.

+    TYPE_WIN = 1,
+    TYPE_MAC = 2,
+    TYPE_LINUX = 3,
+    TYPE_CROS = 4,
+    TYPE_OTHER = 5
+  };
+  DeviceType device_type;

[sky, 2011/08/31 03:35:16]

If this isn't used in chrome/browser/sessions, I don't see the point of putting
it here. If we do need something like this, it should match the typedefs we have
for the platforms: OS_WIN, OS_MACOSX, OS_CHROMEOS...

[Yaron, 2011/08/31 23:23:22]

Well it composes SessionWindows and is related to SessionWindow/SessionTab so I
can see the original motivation to keep it nearby. However, it is only used by
session sync so I moved it out.

As for the comments about matching the typedefs, are you saying I should have
one for each OS in build/build_config.h? Or that I shouldn't need the DeviceType
enum because I can somehow reuse the defines? Or just that the naming should
match the defines?

   std::vector<SessionWindow*> windows;
 };