Set user-visible machine names and devices types for synced sessions.

chrome/browser/sessions/session_types.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_
 #define CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 187 matching lines @@
 };
 
 // Defines a synced session for use by session sync. A synced session is a
 // list of windows along with a unique session identifer (tag).
 struct SyncedSession {
   SyncedSession();
   ~SyncedSession();
 
   // Unique tag for each session.
   std::string session_tag;
+  // User-visible name
+  std::string client_name;
+  // The type of device.
+  enum DeviceType {

[sky, 2011/08/31 03:35:16]

enum before constructor.

[Yaron, 2011/08/31 23:23:22]

Done.

+    TYPE_WIN = 1,
+    TYPE_MAC = 2,
+    TYPE_LINUX = 3,
+    TYPE_CROS = 4,
+    TYPE_OTHER = 5
+  };
+  DeviceType device_type;

[sky, 2011/08/31 03:35:16]

If this isn't used in chrome/browser/sessions, I don't see the point of putting
it here. If we do need something like this, it should match the typedefs we have
for the platforms: OS_WIN, OS_MACOSX, OS_CHROMEOS...

[Yaron, 2011/08/31 23:23:22]

Well it composes SessionWindows and is related to SessionWindow/SessionTab so I
can see the original motivation to keep it nearby. However, it is only used by
session sync so I moved it out.

As for the comments about matching the typedefs, are you saying I should have
one for each OS in build/build_config.h? Or that I shouldn't need the DeviceType
enum because I can somehow reuse the defines? Or just that the naming should
match the defines?

   std::vector<SessionWindow*> windows;
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_