Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/ui/cocoa/info_bubble_window.mm

Issue 7740044: Implement fullscreen info bubble on Win and Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win work Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/info_bubble_window.mm
diff --git a/chrome/browser/ui/cocoa/info_bubble_window.mm b/chrome/browser/ui/cocoa/info_bubble_window.mm
index 6e0e03ae524bee6cb87c16a681a269c1d72390f0..8263ac21325930bd53b84f95d7cb75894f8c334a 100644
--- a/chrome/browser/ui/cocoa/info_bubble_window.mm
+++ b/chrome/browser/ui/cocoa/info_bubble_window.mm
@@ -136,7 +136,7 @@ class AppNotificationBridge : public NotificationObserver {
// case, this is not a desired behavior. As an example, the bubble could have
// buttons.
- (BOOL)canBecomeKeyWindow {
- return YES;
+ return NO;
Scott Hess - ex-Googler 2011/10/10 23:19:50 This needs to be conditional. Avi could probably
jeremya 2011/10/11 05:28:48 Avi who? :)
Scott Hess - ex-Googler 2011/10/11 05:32:30 Drissman, avi@chromium.org, I'm pretty sure he gro
}
// Lets the traffic light buttons on the browser window keep their "active"

Powered by Google App Engine
This is Rietveld 408576698