Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: chrome/browser/ui/cocoa/info_bubble_window.mm

Issue 7740044: Implement fullscreen info bubble on Win and Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win work Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/info_bubble_window.h" 5 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_nsobject.h" 9 #include "base/memory/scoped_nsobject.h"
10 #include "content/common/content_notification_types.h" 10 #include "content/common/content_notification_types.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 } 129 }
130 return self; 130 return self;
131 } 131 }
132 132
133 // According to 133 // According to
134 // http://www.cocoabuilder.com/archive/message/cocoa/2006/6/19/165953, 134 // http://www.cocoabuilder.com/archive/message/cocoa/2006/6/19/165953,
135 // NSBorderlessWindowMask windows cannot become key or main. In this 135 // NSBorderlessWindowMask windows cannot become key or main. In this
136 // case, this is not a desired behavior. As an example, the bubble could have 136 // case, this is not a desired behavior. As an example, the bubble could have
137 // buttons. 137 // buttons.
138 - (BOOL)canBecomeKeyWindow { 138 - (BOOL)canBecomeKeyWindow {
139 return YES; 139 return NO;
Scott Hess - ex-Googler 2011/10/10 23:19:50 This needs to be conditional. Avi could probably
jeremya 2011/10/11 05:28:48 Avi who? :)
Scott Hess - ex-Googler 2011/10/11 05:32:30 Drissman, avi@chromium.org, I'm pretty sure he gro
140 } 140 }
141 141
142 // Lets the traffic light buttons on the browser window keep their "active" 142 // Lets the traffic light buttons on the browser window keep their "active"
143 // state while an info bubble is open. Only has an effect on 10.7. 143 // state while an info bubble is open. Only has an effect on 10.7.
144 - (BOOL)_sharesParentKeyState { 144 - (BOOL)_sharesParentKeyState {
145 return YES; 145 return YES;
146 } 146 }
147 147
148 - (void)close { 148 - (void)close {
149 // Block the window from receiving events while it fades out. 149 // Block the window from receiving events while it fades out.
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 - (void)sendEvent:(NSEvent*)theEvent { 219 - (void)sendEvent:(NSEvent*)theEvent {
220 if (!closing_) 220 if (!closing_)
221 [super sendEvent:theEvent]; 221 [super sendEvent:theEvent];
222 } 222 }
223 223
224 - (BOOL)isClosing { 224 - (BOOL)isClosing {
225 return closing_; 225 return closing_;
226 } 226 }
227 227
228 @end 228 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698