Revert change because one of the previous changes it depends on was reverted.

Revert change because one of the previous changes it depends on was reverted.
http://codereview.chromium.org/7831050/.

BUG=http://code.google.com/p/chromium/issues/detail?id=61022

TBR=scherkus@chromium.org,brettw@chromium.org

[commit-bot: I haz the power, 2011-09-02 23:24:38]

No reviewers yet.

[jam, 2011-09-02 23:28:18]

ping, please IM me first

On Fri, Sep 2, 2011 at 4:27 PM, <enal@chromium.org> wrote:

> Reviewers: brettw, scherkus, wjia,
>
> Description:
> Revert change because one of the previous changes it depends on was
> reverted.
>
http://codereview.chromium.**org/7831050/<http://codereview.chromium.org/7831...
> .
>
>
BUG=http://code.google.com/p/**chromium/issues/detail?id=**61022<http://code.google.com/p/chromium/issues/detail?id=61022>
>
> TBR=scherkus@chromium.org,bret**tw@chromium.org <brettw@chromium.org>
>
> Please review this at
http://codereview.chromium.**org/7739009/<http://codereview.chromium.org/7739...
>
> SVN Base:
http://src.chromium.org/svn/**trunk/src/<http://src.chromium.org/svn/trunk/src/>
>
> Affected files:
>  M     content/browser/renderer_host/**browser_render_process_host.cc
>  M     content/common/content_**switches.h
>  M     content/common/content_**switches.cc
>  M     content/renderer/media/audio_**renderer_impl.cc
>
>
> Index: content/browser/renderer_host/**browser_render_process_host.cc
> ==============================**==============================**=======
> --- content/browser/renderer_host/**browser_render_process_host.cc
>  (revision 99464)
> +++ content/browser/renderer_host/**browser_render_process_host.cc
>  (working copy)
> @@ -582,7 +582,7 @@
>     switches::kInProcessWebGL,
>     switches::kJavaScriptFlags,
>     switches::kLoggingLevel,
> -    switches::kHighLatencyAudio,
> +    switches::kLowLatencyAudio,
>     switches::kNoJsRandomness,
>     switches::kNoReferrers,
>     switches::kNoSandbox,
> Index: content/common/content_**switches.cc
> ==============================**==============================**=======
> --- content/common/content_**switches.cc  (revision 99464)
> +++ content/common/content_**switches.cc  (working copy)
> @@ -279,9 +279,9 @@
>  // Make plugin processes log their sent and received messages to VLOG(1).
>  const char kLogPluginMessages[]             = "log-plugin-messages";
>
> -// Uses high-latency IPC for audio.
> -// That is temporary until we are sure low latency works and remove old
> code.
> -const char kHighLatencyAudio[]               =
> "disable-low-latency-audio";
> +// Uses low-latency IPC for audio.
> +// That is temporary until we make it default and remove old code path.
> +const char kLowLatencyAudio[]               = "enable-low-latency-audio";
>
>  // Causes the process to run as a NativeClient broker
>  // (used for launching NaCl loader processes on 64-bit Windows).
> Index: content/common/content_**switches.h
> ==============================**==============================**=======
> --- content/common/content_**switches.h   (revision 99464)
> +++ content/common/content_**switches.h   (working copy)
> @@ -92,7 +92,7 @@
>  extern const char kLoadPlugin[];
>  extern const char kLoggingLevel[];
>  extern const char kLogPluginMessages[];
> -extern const char kHighLatencyAudio[];
> +extern const char kLowLatencyAudio[];
>  // TODO(jam): this doesn't belong in content.
>  extern const char kNaClBrokerProcess[];
>  extern const char kNaClLoaderProcess[];
> Index: content/renderer/media/audio_**renderer_impl.cc
> ==============================**==============================**=======
> --- content/renderer/media/audio_**renderer_impl.cc       (revision 99464)
> +++ content/renderer/media/audio_**renderer_impl.cc       (working copy)
> @@ -40,8 +40,8 @@
>   // We are initializing only one variable and double initialization is Ok,
>   // so there would not be any issues caused by CPU memory model.
>   if (latency_type_ == kUninitializedLatency) {
> -    if (!CommandLine::**ForCurrentProcess()->**HasSwitch(
> -        switches::kHighLatencyAudio)) {
> +    if (CommandLine::**ForCurrentProcess()->**HasSwitch(
> +        switches::kLowLatencyAudio)) {
>       latency_type_ = kLowLatency;
>     } else {
>       latency_type_ = kHighLatency;
>
>
>

[jam, 2011-09-02 23:29:26]

argh, nm.. i thoguht it was to me because gmail starred it

On Fri, Sep 2, 2011 at 4:28 PM, John Abd-El-Malek <jam@chromium.org> wrote:

> ping, please IM me first
>
>
> On Fri, Sep 2, 2011 at 4:27 PM, <enal@chromium.org> wrote:
>
>> Reviewers: brettw, scherkus, wjia,
>>
>> Description:
>> Revert change because one of the previous changes it depends on was
>> reverted.
>>
http://codereview.chromium.**org/7831050/<http://codereview.chromium.org/7831...
>> .
>>
>>
BUG=http://code.google.com/p/**chromium/issues/detail?id=**61022<http://code.google.com/p/chromium/issues/detail?id=61022>
>>
>> TBR=scherkus@chromium.org,bret**tw@chromium.org <brettw@chromium.org>
>>
>> Please review this at
http://codereview.chromium.**org/7739009/<http://codereview.chromium.org/7739...
>>
>> SVN Base:
http://src.chromium.org/svn/**trunk/src/<http://src.chromium.org/svn/trunk/src/>
>>
>> Affected files:
>>  M     content/browser/renderer_host/**browser_render_process_host.cc
>>  M     content/common/content_**switches.h
>>  M     content/common/content_**switches.cc
>>  M     content/renderer/media/audio_**renderer_impl.cc
>>
>>
>> Index: content/browser/renderer_host/**browser_render_process_host.cc
>> ==============================**==============================**=======
>> --- content/browser/renderer_host/**browser_render_process_host.cc
>>  (revision 99464)
>> +++ content/browser/renderer_host/**browser_render_process_host.cc
>>  (working copy)
>> @@ -582,7 +582,7 @@
>>     switches::kInProcessWebGL,
>>     switches::kJavaScriptFlags,
>>     switches::kLoggingLevel,
>> -    switches::kHighLatencyAudio,
>> +    switches::kLowLatencyAudio,
>>     switches::kNoJsRandomness,
>>     switches::kNoReferrers,
>>     switches::kNoSandbox,
>> Index: content/common/content_**switches.cc
>> ==============================**==============================**=======
>> --- content/common/content_**switches.cc  (revision 99464)
>> +++ content/common/content_**switches.cc  (working copy)
>> @@ -279,9 +279,9 @@
>>  // Make plugin processes log their sent and received messages to VLOG(1).
>>  const char kLogPluginMessages[]             = "log-plugin-messages";
>>
>> -// Uses high-latency IPC for audio.
>> -// That is temporary until we are sure low latency works and remove old
>> code.
>> -const char kHighLatencyAudio[]               =
>> "disable-low-latency-audio";
>> +// Uses low-latency IPC for audio.
>> +// That is temporary until we make it default and remove old code path.
>> +const char kLowLatencyAudio[]               = "enable-low-latency-audio";
>>
>>  // Causes the process to run as a NativeClient broker
>>  // (used for launching NaCl loader processes on 64-bit Windows).
>> Index: content/common/content_**switches.h
>> ==============================**==============================**=======
>> --- content/common/content_**switches.h   (revision 99464)
>> +++ content/common/content_**switches.h   (working copy)
>> @@ -92,7 +92,7 @@
>>  extern const char kLoadPlugin[];
>>  extern const char kLoggingLevel[];
>>  extern const char kLogPluginMessages[];
>> -extern const char kHighLatencyAudio[];
>> +extern const char kLowLatencyAudio[];
>>  // TODO(jam): this doesn't belong in content.
>>  extern const char kNaClBrokerProcess[];
>>  extern const char kNaClLoaderProcess[];
>> Index: content/renderer/media/audio_**renderer_impl.cc
>> ==============================**==============================**=======
>> --- content/renderer/media/audio_**renderer_impl.cc       (revision
>> 99464)
>> +++ content/renderer/media/audio_**renderer_impl.cc       (working copy)
>> @@ -40,8 +40,8 @@
>>   // We are initializing only one variable and double initialization is
>> Ok,
>>   // so there would not be any issues caused by CPU memory model.
>>   if (latency_type_ == kUninitializedLatency) {
>> -    if (!CommandLine::**ForCurrentProcess()->**HasSwitch(
>> -        switches::kHighLatencyAudio)) {
>> +    if (CommandLine::**ForCurrentProcess()->**HasSwitch(
>> +        switches::kLowLatencyAudio)) {
>>       latency_type_ = kLowLatency;
>>     } else {
>>       latency_type_ = kHighLatency;
>>
>>
>>
>

[wjia(left Chromium), 2011-09-02 23:46:20]

lgtm

[brettw, 2011-09-06 21:12:01]

LGTM rubberstamp

[commit-bot: I haz the power, 2011-09-07 01:41:45]

Change committed as 99891