Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7737013: Move PPAPI graphics3d and opengles interfaces out of Dev. (Closed)

Created:
9 years, 3 months ago by nfullagar
Modified:
9 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Move PPAPI graphics3d and opengles interfaces out of Dev. BUG= http://code.google.com/p/chromium/issues/detail?id=94320 TEST= various nacl exmaples, try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99855

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -1147 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 5 6 4 chunks +7 lines, -7 lines 0 comments Download
M gpu/demos/framework/pepper.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
D ppapi/c/dev/pp_graphics_3d_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -48 lines 0 comments Download
M ppapi/c/dev/pp_video_dev.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_context_3d_dev.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D ppapi/c/dev/ppb_graphics_3d_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -204 lines 0 comments Download
D ppapi/c/dev/ppb_graphics_3d_trusted_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -103 lines 0 comments Download
D ppapi/c/dev/ppb_opengles_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -308 lines 0 comments Download
M ppapi/c/dev/ppb_surface_3d_dev.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D ppapi/c/dev/ppp_graphics_3d_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -18 lines 0 comments Download
A + ppapi/c/pp_graphics_3d.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/c/ppb_graphics_3d.h View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
A + ppapi/c/ppb_opengles.h View 1 2 3 4 3 chunks +6 lines, -9 lines 0 comments Download
A + ppapi/c/ppp_graphics_3d.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
A + ppapi/c/trusted/ppb_graphics_3d_trusted.h View 3 chunks +8 lines, -8 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_client_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_client_dev.cc View 1 2 3 4 5 6 1 chunk +0 lines, -43 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_dev.h View 1 2 3 4 5 6 1 chunk +0 lines, -39 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_dev.cc View 1 2 3 4 5 6 1 chunk +0 lines, -76 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + ppapi/cpp/graphics_3d.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + ppapi/cpp/graphics_3d.cc View 2 chunks +22 lines, -22 lines 0 comments Download
A + ppapi/cpp/graphics_3d_client.h View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments Download
A + ppapi/cpp/graphics_3d_client.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/cpp/instance.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/cpp/instance.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/examples/gles2/gles2.cc View 1 2 3 4 5 6 6 chunks +9 lines, -9 lines 0 comments Download
M ppapi/lib/gl/gles2/gl2ext_ppapi.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/lib/gl/gles2/gl2ext_ppapi.c View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.h View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.h View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -10 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc View 1 2 3 4 5 6 7 3 chunks +1 line, -5 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc View 1 2 3 4 5 6 8 chunks +97 lines, -13 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.html View 1 2 3 4 5 6 3 chunks +10 lines, -2 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.h View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.cc View 1 2 3 4 5 6 6 chunks +12 lines, -12 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 2 3 4 5 6 8 chunks +8 lines, -9 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M ppapi/proxy/interface_id.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_opengles2_proxy.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.cc View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/opengles2_impl.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/opengles2_impl.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 3 4 5 6 6 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_graphics_3d.h View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/test_graphics_3d.cc View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_thunk.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M ppapi/thunk/thunk.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 5 6 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_opengles_impl.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_opengles_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nfullagar
9 years, 3 months ago (2011-09-04 02:03:52 UTC) #1
brettw
LGTM http://codereview.chromium.org/7737013/diff/1099/ppapi/c/ppb_graphics_3d.h File ppapi/c/ppb_graphics_3d.h (right): http://codereview.chromium.org/7737013/diff/1099/ppapi/c/ppb_graphics_3d.h#newcode31 ppapi/c/ppb_graphics_3d.h:31: #define PPB_GRAPHICS_3D_INTERFACE_0_9 "PPB_Graphics3D;0.9" Can you update this to ...
9 years, 3 months ago (2011-09-06 16:34:40 UTC) #2
commit-bot: I haz the power
Can't process patch for file ppapi/cpp/graphics_3d.h. A +
9 years, 3 months ago (2011-09-06 22:39:53 UTC) #3
nfullagar
9 years, 3 months ago (2011-09-06 23:13:55 UTC) #4 
After talking w/ Bradley, apparently commit bot can't handle A+ files generated
w/ svn move, so attempting to gcl commit manually at r99855

Powered by Google App Engine
This is Rietveld 408576698