Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 7736006: Add more functionality to graphics3d test (more to follow...) (Closed)

Created:
9 years, 3 months ago by nfullagar
Modified:
9 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Add more functionality to graphics3d test (more to follow...) - Call Core->ReleaseResource() on multiple graphics3d resources. Fix for NaCl ppapi graphics 3d resource, so it can be released without crashing the untrusted plugin. Add a few more debug prints for future use. BUG= none TEST= ppapi_ppb_graphics3d.cc (included) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nfullagar
9 years, 3 months ago (2011-08-27 23:42:42 UTC) #1
brettw
LGTM
9 years, 3 months ago (2011-08-28 16:56:42 UTC) #2
nfullagar
9 years, 3 months ago (2011-08-29 20:27:52 UTC) #3
thx, committed r98686

Powered by Google App Engine
This is Rietveld 408576698