Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc

Issue 7736006: Add more functionality to graphics3d test (more to follow...) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc
===================================================================
--- ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc (revision 98247)
+++ ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc (working copy)
@@ -60,6 +60,7 @@
PP_Resource graphics3d_id = PPBGraphics3DDev()->
Create(pp_instance(), kInvalidResource, attribs);
EXPECT(graphics3d_id != kInvalidResource);
+ PPBCore()->ReleaseResource(graphics3d_id);
PP_Resource invalid_graphics3d_id = PPBGraphics3DDev()->
Create(0, kInvalidResource, attribs);
EXPECT(invalid_graphics3d_id == kInvalidResource);
@@ -68,9 +69,11 @@
PP_Resource graphics3d_empty_attrib_id = PPBGraphics3DDev()->
Create(pp_instance(), kInvalidResource, empty_attribs);
EXPECT(graphics3d_empty_attrib_id != kInvalidResource);
+ PPBCore()->ReleaseResource(graphics3d_empty_attrib_id);
PP_Resource graphics3d_null_attrib_id = PPBGraphics3DDev()->
Create(pp_instance(), kInvalidResource, NULL);
EXPECT(graphics3d_null_attrib_id != kInvalidResource);
+ PPBCore()->ReleaseResource(graphics3d_null_attrib_id);
TEST_PASSED;
}
@@ -84,6 +87,7 @@
Create(pp_instance(), kInvalidResource, attribs);
EXPECT(graphics3d_id != kInvalidResource);
EXPECT(PPBGraphics3DDev()->IsGraphics3D(graphics3d_id) == PP_TRUE);
+ PPBCore()->ReleaseResource(graphics3d_id);
TEST_PASSED;
}
@@ -109,6 +113,7 @@
int32_t result = PPBGraphics3DDev()->SwapBuffers(info->graphics3d_id, cc);
CHECK(PP_OK_COMPLETIONPENDING == result);
} else {
+ PPBCore()->ReleaseResource(info->graphics3d_id);
delete info;
}
glSetCurrentContextPPAPI(0);
« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698