Issue 7736002: Make the mac service process handling code clean itself up properly as far as launchd is concerned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7736002: Make the mac service process handling code clean itself up properly as far as launchd is concerned. (Closed)

Created:
9 years, 4 months ago by dmac

Modified:
9 years, 4 months ago

Reviewers:
Scott Byer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make the mac service process handling code clean itself up properly as far as launchd is concerned. Note new documentation at https://sites.google.com/a/chromium.org/dev/developers/design-documents/service-processes BUG=None TEST= 1) Build. 2) Launch Chromium with cloud print disabled. 3) Start Terminal 4) launchctl list 5) You should not see any org.chromium.Chromium.framework.service_process/* processes listed 6) Go to Preferences in chromium 7) launchctl list 8) You should now see a org.chromium.Chromium.framework.service_process/* process 9) Quit chromium 10) launchctl list 11) There should not be any org.chromium.Chromium.framework.service_process/* processes anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98221

Patch Set 1 #

Patch Set 2 : add launchd test #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -59 lines)			Patch
M	chrome/common/service_process_util.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/service_process_util_mac.mm	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/common/service_process_util_posix.h	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/common/service_process_util_posix.cc	View		5 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/common/service_process_util_unittest.cc	View	1	3 chunks	+24 lines, -3 lines	0 comments	Download
M	chrome/common/service_process_util_win.cc	View		5 chunks	+26 lines, -24 lines	0 comments	Download
M	chrome/service/service_process.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/service/service_process.cc	View		2 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2011/08/24 21:35:46, dmac wrote:
> PTAL

Expand Messages | Collapse Messages