Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/common/service_process_util_mac.mm

Issue 7736002: Make the mac service process handling code clean itself up properly as far as launchd is concerned. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add launchd test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util.h ('k') | chrome/common/service_process_util_posix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/service_process_util_mac.mm
diff --git a/chrome/common/service_process_util_mac.mm b/chrome/common/service_process_util_mac.mm
index 7923a1a987893e2da01fb63a0357160729cda64d..df2bc22fcbcde5d95079e6b645433795c2a6f7ec 100644
--- a/chrome/common/service_process_util_mac.mm
+++ b/chrome/common/service_process_util_mac.mm
@@ -120,7 +120,8 @@ bool ForceServiceProcessShutdown(const std::string& /* version */,
CFErrorRef err = NULL;
bool ret = Launchd::GetInstance()->RemoveJob(label, &err);
if (!ret) {
- LOG(ERROR) << "ForceServiceProcessShutdown: " << err;
+ LOG(ERROR) << "ForceServiceProcessShutdown: " << err << " "
+ << base::SysCFStringRefToUTF8(label);
CFRelease(err);
}
return ret;
@@ -177,9 +178,9 @@ bool ServiceProcessState::Initialize() {
CFErrorRef err = NULL;
CFDictionaryRef dict =
Launchd::GetInstance()->CopyDictionaryByCheckingIn(&err);
-
if (!dict) {
- LOG(ERROR) << "CopyLaunchdDictionaryByCheckingIn: " << err;
+ LOG(ERROR) << "ServiceProcess must be launched by launchd. "
+ << "CopyLaunchdDictionaryByCheckingIn: " << err;
CFRelease(err);
return false;
}
« no previous file with comments | « chrome/common/service_process_util.h ('k') | chrome/common/service_process_util_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698