Issue 7735001: Add a iconUrl parameter to webstorePrivate.beginInstallWithManifest2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7735001: Add a iconUrl parameter to webstorePrivate.beginInstallWithManifest2 (Closed)

Created:
9 years, 4 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 4 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add a iconUrl parameter to webstorePrivate.beginInstallWithManifest2 The webstore folks were finding it inconvenient to use javascript and a canvas tag to get the base64 encoded data for the icon, and asked us to just add this parameter to have the client fetch it. BUG=93546 TEST=Includes a browser test, but requires webstore server changes to fully test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98182

Patch Set 1 : ready for review #

Patch Set 2 : rebased #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -21 lines)			Patch
M	chrome/browser/extensions/extension_webstore_private_api.h	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View	1	7 chunks	+114 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_apitest.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/webstore_private/icon_url.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webstore_private/icon_url.js	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages