Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: chrome/browser/extensions/extension_webstore_private_api.h

Issue 7735001: Add a iconUrl parameter to webstorePrivate.beginInstallWithManifest2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_webstore_private_api.h
diff --git a/chrome/browser/extensions/extension_webstore_private_api.h b/chrome/browser/extensions/extension_webstore_private_api.h
index 081e6b7e2074212ab496c0cf1e6705b9b04c10b6..12dc023733707655543975494cb179e9aaef8cb8 100644
--- a/chrome/browser/extensions/extension_webstore_private_api.h
+++ b/chrome/browser/extensions/extension_webstore_private_api.h
@@ -71,6 +71,9 @@ class BeginInstallWithManifestFunction : public AsyncExtensionFunction,
// The function was not called during a user gesture.
NO_GESTURE,
+
+ // Invalid icon url.
+ INVALID_ICON_URL
};
// For use only in tests - sets a flag that can cause this function to ignore
@@ -82,13 +85,13 @@ class BeginInstallWithManifestFunction : public AsyncExtensionFunction,
// as if the dialog choice was to proceed or abort.
static void SetAutoConfirmForTests(bool should_proceed);
- // Called when we've successfully parsed the manifest and icon data in the
- // utility process. Ownership of parsed_manifest is transferred.
+ // Called when we've successfully parsed the manifest and decoded the icon in
+ // the utility process. Ownership of parsed_manifest is transferred.
void OnParseSuccess(const SkBitmap& icon,
base::DictionaryValue* parsed_manifest);
// Called to indicate a parse failure. The |result_code| parameter should
- // indicate whether the problem was with the manifest or icon data.
+ // indicate whether the problem was with the manifest or icon.
void OnParseFailure(ResultCode result_code, const std::string& error_message);
// Implementing ExtensionInstallUI::Delegate interface.
@@ -117,6 +120,7 @@ class BeginInstallWithManifestFunction : public AsyncExtensionFunction,
// A dummy Extension object we create for the purposes of using
// ExtensionInstallUI to prompt for confirmation of the install.
scoped_refptr<Extension> dummy_extension_;
+
DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest2");
};
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_webstore_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698