Issue 7729007: Focus/InputMethod fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7729007: Focus/InputMethod fix. (Closed)

Created:
9 years, 4 months ago by oshima

Modified:
9 years, 4 months ago

Reviewers:
Peng

CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

* Fix wrong condition check in OnFocusOut. * Create inputmethod only when it's requested via Widget::GetInputMethod. This is what original code did. BUG=none TEST=added WidgetTest::ChangeActivation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98118

Patch Set 1 #

Patch Set 2 : " #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -7 lines)			Patch
M	views/widget/native_widget_gtk.cc	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	views/widget/widget.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	views/widget/widget_unittest.cc	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/08/24 20:17:14, oshima wrote:
LGTM. Thx.

Expand Messages | Collapse Messages