Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: views/widget/widget.cc

Issue 7729007: Focus/InputMethod fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/widget/native_widget_gtk.cc ('k') | views/widget/widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/widget.cc
diff --git a/views/widget/widget.cc b/views/widget/widget.cc
index 07a6687a2eb13eb55aa613de75cb4e491245faa2..45423c6d40fa633753d1b3be05d21f06acc15712 100644
--- a/views/widget/widget.cc
+++ b/views/widget/widget.cc
@@ -596,8 +596,14 @@ FocusManager* Widget::GetFocusManager() {
}
InputMethod* Widget::GetInputMethod() {
- Widget* toplevel_widget = GetTopLevelWidget();
- return toplevel_widget ? toplevel_widget->GetInputMethodDirect() : NULL;
+ if (is_top_level()) {
+ if (!input_method_.get())
+ ReplaceInputMethod(native_widget_->CreateInputMethod());
+ return input_method_.get();
+ } else {
+ Widget* toplevel = GetTopLevelWidget();
+ return toplevel ? toplevel->GetInputMethod() : NULL;
+ }
}
void Widget::RunShellDrag(View* view, const ui::OSExchangeData& data,
@@ -976,8 +982,6 @@ bool Widget::ExecuteCommand(int command_id) {
}
InputMethod* Widget::GetInputMethodDirect() {
- if (!input_method_.get() && is_top_level())
- ReplaceInputMethod(native_widget_->CreateInputMethod());
return input_method_.get();
}
« no previous file with comments | « views/widget/native_widget_gtk.cc ('k') | views/widget/widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698