Get rid of link dependency from content to chrome. Make it get the SpeechInputManager through the...

Get rid of link dependency from content to chrome. Make it get the SpeechInputManager through the embedder interface.

I've renamed Chrome's SpeechInputManagerImpl to ChromeSpeechInputManager, to match what we've been doing for other chrome implementations of content classes.

BUG=76697
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98147

[Paweł Hajdan Jr., 2011-08-24 22:57:11]

LGTM with a comment.

http://codereview.chromium.org/7729001/diff/8001/chrome/browser/speech/chrome...
File chrome/browser/speech/chrome_speech_input_manager.h (right):

http://codereview.chromium.org/7729001/diff/8001/chrome/browser/speech/chrome...
chrome/browser/speech/chrome_speech_input_manager.h:82: };
nit: No DISALLOW_COPY_AND_ASSIGN?

[jam, 2011-08-24 23:08:56]

http://codereview.chromium.org/7729001/diff/8001/chrome/browser/speech/chrome...
File chrome/browser/speech/chrome_speech_input_manager.h (right):

http://codereview.chromium.org/7729001/diff/8001/chrome/browser/speech/chrome...
chrome/browser/speech/chrome_speech_input_manager.h:82: };
On 2011/08/24 22:57:11, Paweł Hajdan Jr. wrote:
> nit: No DISALLOW_COPY_AND_ASSIGN?

I had just moved this, but I'll add it and hopefully nothing breaks :)

[jam, 2011-08-24 23:44:08]

Satish: I'm going to TBR this simple rename since you're the only one in the
OWNERS file for chrome\browser\speech. The change is making the speech
content/chrome a little neater, since when I originally split speech I was in a
hurry and left the header with interface in content and moved the cc file to
chrome. I've now split the chrome cc file into another header. This matches what
we do with other chrome implementations that have the interface in content.

[Satish, 2011-08-25 09:08:52]

Thanks for the change.

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
File content/browser/speech/speech_input_manager.cc (right):

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
content/browser/speech/speech_input_manager.cc:18: void
SpeechInputManager::ShowAudioInputSettings() {
was this moved from the chrome/ to content/ because something was depending on
it or because it didn't depend on the rest of chrome/ code?

If it is the latter, there is a lot more of ChromeSpeechInputManager which
doesn't depend on chrome/ (IIRC only the bubble related code needs to be there
and the rest can move here).

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
File content/browser/speech/speech_input_manager.h (right):

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
content/browser/speech/speech_input_manager.h:18: // This class is a singleton
and accessed via the Get method.
Need to update this comment since the Get() method was removed below.

[jam, 2011-08-25 16:36:43]

Thanks for looking, sending a followup now

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
File content/browser/speech/speech_input_manager.cc (right):

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
content/browser/speech/speech_input_manager.cc:18: void
SpeechInputManager::ShowAudioInputSettings() {
On 2011/08/25 09:08:52, Satish wrote:
> was this moved from the chrome/ to content/ because something was depending on
> it or because it didn't depend on the rest of chrome/ code?

It was moved because other content code depended on it
(SpeechInputDispatcherHost)

> 
> If it is the latter, there is a lot more of ChromeSpeechInputManager which
> doesn't depend on chrome/ (IIRC only the bubble related code needs to be there
> and the rest can move here).

If this can be moved, and the chrome parts abstracted out, that would be great
(esp if someone more familiar with speech than me can do it :) ). right now it
also has dependencies on grit, prefsservice, g_browser_process and
WMIComputerSystem (not sure what that is, it's from the installer dir) that
would need to be factored out

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
File content/browser/speech/speech_input_manager.h (right):

http://codereview.chromium.org/7729001/diff/13003/content/browser/speech/spee...
content/browser/speech/speech_input_manager.h:18: // This class is a singleton
and accessed via the Get method.
On 2011/08/25 09:08:52, Satish wrote:
> Need to update this comment since the Get() method was removed below.

done (moved it to the chrome impl)