Get rid of link dependency from content to chrome. Make it get the SpeechInputManager through the...

content/browser/speech/speech_input_manager.cc

Index: content/browser/speech/speech_input_manager.cc
===================================================================
--- content/browser/speech/speech_input_manager.cc	(revision 0)
+++ content/browser/speech/speech_input_manager.cc	(revision 0)
@@ -0,0 +1,33 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/speech/speech_input_manager.h"
+
+#include "content/browser/browser_thread.h"
+#include "media/audio/audio_manager.h"
+
+namespace speech_input {
+
+SpeechInputManager::SpeechInputManager() : censor_results_(true) {
+}
+
+SpeechInputManager::~SpeechInputManager() {
+}
+
+void SpeechInputManager::ShowAudioInputSettings() {

[Satish, 2011/08/25 09:08:52]

was this moved from the chrome/ to content/ because something was depending on
it or because it didn't depend on the rest of chrome/ code?

If it is the latter, there is a lot more of ChromeSpeechInputManager which
doesn't depend on chrome/ (IIRC only the bubble related code needs to be there
and the rest can move here).

[jam, 2011/08/25 16:36:43]

It was moved because other content code depended on it
(SpeechInputDispatcherHost)
If this can be moved, and the chrome parts abstracted out, that would be great
(esp if someone more familiar with speech than me can do it :) ). right now it
also has dependencies on grit, prefsservice, g_browser_process and
WMIComputerSystem (not sure what that is, it's from the installer dir) that
would need to be factored out

+  // Since AudioManager::ShowAudioInputSettings can potentially launch external
+  // processes, do that in the FILE thread to not block the calling threads.
+  if (!BrowserThread::CurrentlyOn(BrowserThread::FILE)) {
+    BrowserThread::PostTask(
+        BrowserThread::FILE, FROM_HERE,
+        NewRunnableFunction(&SpeechInputManager::ShowAudioInputSettings));
+    return;
+  }
+
+  DCHECK(AudioManager::GetAudioManager()->CanShowAudioInputSettings());
+  if (AudioManager::GetAudioManager()->CanShowAudioInputSettings())
+    AudioManager::GetAudioManager()->ShowAudioInputSettings();
+}
+
+}  // namespace speech_input
Property changes on: content\browser\speech\speech_input_manager.cc
___________________________________________________________________
Added: svn:eol-style
   + LF