Add a gyp flag to enable dcheck by default in release without

base/logging.h

Index: base/logging.h
===================================================================
--- base/logging.h	(revision 97912)
+++ base/logging.h	(working copy)
@@ -624,10 +624,15 @@
 #define COMPACT_GOOGLE_LOG_DCHECK COMPACT_GOOGLE_LOG_ERROR_REPORT
 const LogSeverity LOG_DCHECK = LOG_ERROR_REPORT;
 BASE_EXPORT extern DcheckState g_dcheck_state;
+
+#if defined(DCHECK_ALWAYS_ON)
+#define DCHECK_IS_ON() true
+#else // defined(DCHECK_ALWAYS_ON)

[rvargas (doing something else), 2011/08/23 22:03:59]

nit: I think the comment adds more noise than value.

 #define DCHECK_IS_ON()                                                  \
   ((::logging::g_dcheck_state ==                                        \
     ::logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS) &&        \
    LOG_IS_ON(DCHECK))

[rvargas (doing something else), 2011/08/23 22:03:59]

this line looks broken to me (before this CL). If it works, it should be part of
the #if.

+#endif // defined(DCHECK_ALWAYS_ON)

[rvargas (doing something else), 2011/08/23 22:03:59]

nit: two spaces before comments.

 
 #else  // defined(NDEBUG)