Add a gyp flag to enable dcheck by default in release without

base/logging.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOGGING_H_
 #define BASE_LOGGING_H_
 #pragma once
 
 #include <cassert>
 #include <string>
@@ skipping 606 matching lines @@
 
 #if ENABLE_DCHECK
 
 #if defined(NDEBUG)
 
 #define COMPACT_GOOGLE_LOG_EX_DCHECK(ClassName, ...) \
   COMPACT_GOOGLE_LOG_EX_ERROR_REPORT(ClassName , ##__VA_ARGS__)
 #define COMPACT_GOOGLE_LOG_DCHECK COMPACT_GOOGLE_LOG_ERROR_REPORT
 const LogSeverity LOG_DCHECK = LOG_ERROR_REPORT;
 BASE_EXPORT extern DcheckState g_dcheck_state;
+
+#if defined(DCHECK_ALWAYS_ON)
+#define DCHECK_IS_ON() true
+#else // defined(DCHECK_ALWAYS_ON)

[rvargas (doing something else), 2011/08/23 22:03:59]

nit: I think the comment adds more noise than value.

 #define DCHECK_IS_ON()                                                  \
   ((::logging::g_dcheck_state ==                                        \
     ::logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS) &&        \
    LOG_IS_ON(DCHECK))

[rvargas (doing something else), 2011/08/23 22:03:59]

this line looks broken to me (before this CL). If it works, it should be part of
the #if.

+#endif // defined(DCHECK_ALWAYS_ON)

[rvargas (doing something else), 2011/08/23 22:03:59]

nit: two spaces before comments.

 
 #else  // defined(NDEBUG)
 
 // On a regular debug build, we want to have DCHECKs enabled.
 #define COMPACT_GOOGLE_LOG_EX_DCHECK(ClassName, ...) \
   COMPACT_GOOGLE_LOG_EX_FATAL(ClassName , ##__VA_ARGS__)
 #define COMPACT_GOOGLE_LOG_DCHECK COMPACT_GOOGLE_LOG_FATAL
 const LogSeverity LOG_DCHECK = LOG_FATAL;
 #define DCHECK_IS_ON() true
 
@@ skipping 302 matching lines @@
 namespace base {
 
 class StringPiece;
 
 // Allows StringPiece to be logged.
 BASE_EXPORT std::ostream& operator<<(std::ostream& o, const StringPiece& piece);
 
 }  // namespace base
 
 #endif  // BASE_LOGGING_H_