Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: chrome/common/logging_chrome.cc

Issue 7719007: Add a gyp flag to enable dcheck by default in release without (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
===================================================================
--- chrome/common/logging_chrome.cc (revision 97896)
+++ chrome/common/logging_chrome.cc (working copy)
@@ -243,10 +243,15 @@
// Always force a new symlink when redirecting.
FilePath target_path = SetUpSymlinkIfNeeded(log_path, true);
+#if defined(DCHECK_ALWAYS_ON)
logging::DcheckState dcheck_state =
+ logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS
+#else
+ logging::DcheckState dcheck_state =
command_line.HasSwitch(switches::kEnableDCHECK) ?
logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS :
logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS;
+#endif
// ChromeOS always logs through the symlink, so it shouldn't be
// deleted if it already exists.
@@ -304,10 +309,15 @@
#endif
}
+#if defined(DCHECK_ALWAYS_ON)
logging::DcheckState dcheck_state =
+ logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS
+#else
+ logging::DcheckState dcheck_state =
command_line.HasSwitch(switches::kEnableDCHECK) ?
logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS :
logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS;
+#endif
bool success = InitLogging(log_path.value().c_str(),
logging_dest,
« no previous file with comments | « build/common.gypi ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698