Add a gyp flag to enable dcheck by default in release without

chrome/common/logging_chrome.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 // Need to include this before most other files because it defines
 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
 // IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the
 // ViewMsgLog et al. functions.
@@ skipping 225 matching lines @@
   // Redirect logs to the session log directory, if set.  Otherwise
   // defaults to the profile dir.
   FilePath log_path = GetSessionLogFile(command_line);
 
   // Creating symlink causes us to do blocking IO on UI thread.
   // Temporarily allow it until we fix http://crbug.com/61143
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   // Always force a new symlink when redirecting.
   FilePath target_path = SetUpSymlinkIfNeeded(log_path, true);
 
+#if defined(DCHECK_ALWAYS_ON)
+  logging::DcheckState dcheck_state =
+      logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS
+#else
   logging::DcheckState dcheck_state =
       command_line.HasSwitch(switches::kEnableDCHECK) ?
       logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS :
       logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS;
+#endif
 
   // ChromeOS always logs through the symlink, so it shouldn't be
   // deleted if it already exists.
   if (!InitLogging(log_path.value().c_str(),
                    DetermineLogMode(command_line),
                    logging::LOCK_LOG_FILE,
                    logging::APPEND_TO_OLD_LOG_FILE,
                    dcheck_state)) {
     LOG(ERROR) << "Unable to initialize logging to " << log_path.value();
     RemoveSymlinkAndLog(log_path, target_path);
@@ skipping 37 matching lines @@
     target_path = SetUpSymlinkIfNeeded(
         log_path, delete_old_log_file == logging::DELETE_OLD_LOG_FILE);
 
     // Because ChromeOS manages the move to a new session by redirecting
     // the link, it shouldn't remove the old file in the logging code,
     // since that will remove the newly created link instead.
     delete_old_log_file = logging::APPEND_TO_OLD_LOG_FILE;
 #endif
   }
 
+#if defined(DCHECK_ALWAYS_ON)
+  logging::DcheckState dcheck_state =
+      logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS
+#else
   logging::DcheckState dcheck_state =
       command_line.HasSwitch(switches::kEnableDCHECK) ?
       logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS :
       logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS;
+#endif
 
   bool success = InitLogging(log_path.value().c_str(),
                              logging_dest,
                              logging::LOCK_LOG_FILE,
                              delete_old_log_file,
                              dcheck_state);
 
 #if defined(OS_CHROMEOS)
   if (!success) {
     PLOG(ERROR) << "Unable to initialize logging to " << log_path.value()
@@ skipping 44 matching lines @@
   }
 
 #if defined(OS_WIN)
   // Enable trace control and transport through event tracing for Windows.
   if (env->HasVar(env_vars::kEtwLogging))
     logging::LogEventProvider::Initialize(kChromeTraceProviderName);
 #endif
 
 #ifdef NDEBUG
   if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK) &&
       command_line.HasSwitch(switches::kEnableDCHECK)) {

[rvargas (doing something else), 2011/08/23 20:48:22]

Looks like we need another condition here :(

 #if defined(OS_WIN)
     logging::SetLogReportHandler(DumpProcessAssertHandler);
 #endif
   }
 #endif  // NDEBUG
 
   chrome_logging_initialized_ = true;
 }
 
 // This is a no-op, but we'll keep it around in case
@@ skipping 60 matching lines @@
         assertions->push_back(wide_line);
       ++assertion_count;
     }
   }
   log_file.close();
 
   return assertion_count;
 }
 
 }  // namespace logging