Do not call callback->Run() until we are about to return from this

net/http/disk_cache_based_ssl_host_info.h

Index: net/http/disk_cache_based_ssl_host_info.h
===================================================================
--- net/http/disk_cache_based_ssl_host_info.h	(revision 97879)
+++ net/http/disk_cache_based_ssl_host_info.h	(working copy)
@@ -23,8 +23,9 @@
 // DiskCacheBasedSSLHostInfo fetches information about an SSL host from our
 // standard disk cache. Since the information is defined to be non-sensitive,
 // it's ok for us to keep it on disk.
-class DiskCacheBasedSSLHostInfo : public SSLHostInfo,
-                                  public base::NonThreadSafe {
+class NET_EXPORT_PRIVATE DiskCacheBasedSSLHostInfo
+    : public SSLHostInfo,

[rvargas (doing something else), 2011/08/23 18:20:48]

SSLHostInfo also has to be exported.

+      public NON_EXPORTED_BASE(base::NonThreadSafe) {
  public:
   DiskCacheBasedSSLHostInfo(const std::string& hostname,
                             const SSLConfig& ssl_config,
@@ -79,8 +80,10 @@
 
   std::string key() const;
 
-  void DoLoop(int rv);
+  void OnIOComplete(int rv);
 
+  int DoLoop(int rv);
+
   int DoGetBackendComplete(int rv);
   int DoOpenComplete(int rv);
   int DoReadComplete(int rv);
@@ -112,8 +115,8 @@
   disk_cache::Backend* backend_;
   disk_cache::Entry* entry_;
   CompletionCallback* user_callback_;
-  scoped_refptr<net::IOBuffer> read_buffer_;
-  scoped_refptr<net::IOBuffer> write_buffer_;
+  scoped_refptr<IOBuffer> read_buffer_;
+  scoped_refptr<IOBuffer> write_buffer_;
   std::string data_;
 };