Do not call callback->Run() until we are about to return from this

net/http/disk_cache_based_ssl_host_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_
 #define NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/completion_callback.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/socket/ssl_host_info.h"
 
 namespace net {
 
 class HttpCache;
 class IOBuffer;
 struct SSLConfig;
 
 // DiskCacheBasedSSLHostInfo fetches information about an SSL host from our
 // standard disk cache. Since the information is defined to be non-sensitive,
 // it's ok for us to keep it on disk.
-class DiskCacheBasedSSLHostInfo : public SSLHostInfo,
-                                  public base::NonThreadSafe {
+class NET_EXPORT_PRIVATE DiskCacheBasedSSLHostInfo
+    : public SSLHostInfo,

[rvargas (doing something else), 2011/08/23 18:20:48]

SSLHostInfo also has to be exported.

+      public NON_EXPORTED_BASE(base::NonThreadSafe) {
  public:
   DiskCacheBasedSSLHostInfo(const std::string& hostname,
                             const SSLConfig& ssl_config,
                             CertVerifier* cert_verifier,
                             HttpCache* http_cache);
 
   // Implementation of SSLHostInfo
   virtual void Start();
   virtual int WaitForDataReady(CompletionCallback* callback);
   virtual void Persist();
@@ skipping 34 matching lines @@
     void (DiskCacheBasedSSLHostInfo::*meth_)(int);
 
     disk_cache::Backend* backend_;
     disk_cache::Entry* entry_;
   };
 
   virtual ~DiskCacheBasedSSLHostInfo();
 
   std::string key() const;
 
-  void DoLoop(int rv);
+  void OnIOComplete(int rv);
+
+  int DoLoop(int rv);
 
   int DoGetBackendComplete(int rv);
   int DoOpenComplete(int rv);
   int DoReadComplete(int rv);
   int DoWriteComplete(int rv);
   int DoCreateComplete(int rv);
 
   int DoGetBackend();
   int DoOpen();
   int DoRead();
@@ skipping 12 matching lines @@
   base::WeakPtrFactory<DiskCacheBasedSSLHostInfo> weak_ptr_factory_;
   CallbackImpl* callback_;
   State state_;
   bool ready_;
   std::string new_data_;
   const std::string hostname_;
   HttpCache* const http_cache_;
   disk_cache::Backend* backend_;
   disk_cache::Entry* entry_;
   CompletionCallback* user_callback_;
-  scoped_refptr<net::IOBuffer> read_buffer_;
-  scoped_refptr<net::IOBuffer> write_buffer_;
+  scoped_refptr<IOBuffer> read_buffer_;
+  scoped_refptr<IOBuffer> write_buffer_;
   std::string data_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_