Issue 7714027: Mark ParseHostAndPort() as NET_EXPORT instead of NET_EXPORT_PRIVATE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7714027: Mark ParseHostAndPort() as NET_EXPORT instead of NET_EXPORT_PRIVATE. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 3 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mark ParseHostAndPort() as NET_EXPORT instead of NET_EXPORT_PRIVATE. I need to use this function in content/rendeder/p2p. TEST=None BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98666

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/base/net_util.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (0 generated)

willchan no longer on Chromium

I'm on vacation in India, sorry. Ping another OWNER. On Aug 25, 2011 11:48 PM, ...

9 years, 4 months ago (2011-08-25 18:39:55 UTC) #3

wtc

I think this is fine. In the CL's commit message, NET_EXPORT_PUBLIC is a typo. Please ...

9 years, 4 months ago (2011-08-25 19:09:20 UTC) #5

eroman

9 years, 3 months ago (2011-08-29 18:39:30 UTC) #8

LGTM

(I didn't realize there was an outstanding question for me!)