chrome/renderer/extensions/extension_process_bindings.cc - Issue 7714004: base: Add AsList() function to Value API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_process_bindings.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/extension_process_bindings.cc

diff --git a/chrome/renderer/extensions/extension_process_bindings.cc b/chrome/renderer/extensions/extension_process_bindings.cc

index d96743cc9298ed88d9403869523f2d681120cdc1..9c45e465724e44d5f33ea898314dd2bcc49eb9d3 100644

--- a/chrome/renderer/extensions/extension_process_bindings.cc

+++ b/chrome/renderer/extensions/extension_process_bindings.cc

@@ -467,7 +467,7 @@ class ExtensionImpl : public ExtensionBase {

// Since we do the serialization in the v8 extension, we should always get

// valid JSON.

- if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) {

+ if (!value_args.get() || !value_args->AsList()) {

NOTREACHED() << "Invalid JSON passed to StartRequest.";

return v8::Undefined();

}