Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 7711007: Add custom overhang pattern for rubber-banding. (Closed)

Created:
9 years, 4 months ago by Alexei Svitkine (slow)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Nico
Visibility:
Public.

Description

Add custom overhang pattern for rubber-banding. This will be used in WebKit for overhang painting. BUG=93397 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97855

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A webkit/glue/resources/overhang_pattern.png View Binary file 0 comments Download
M webkit/glue/webkit_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
9 years, 4 months ago (2011-08-22 18:25:54 UTC) #1
tony
Is this only going to be used by DRT or will it be used by ...
9 years, 4 months ago (2011-08-22 18:28:57 UTC) #2
sail
Updated the bug with a new image. Thanks!
9 years, 4 months ago (2011-08-22 18:33:37 UTC) #3
Alexei Svitkine (slow)
On 2011/08/22 18:28:57, tony wrote: > Is this only going to be used by DRT ...
9 years, 4 months ago (2011-08-22 18:41:22 UTC) #4
tony
LGTM. 20k seems like a lot of size to add to Win/Linux for something that ...
9 years, 4 months ago (2011-08-22 19:11:20 UTC) #5
Alexei Svitkine (slow)
> 20k seems like a lot of size to add to Win/Linux for something that ...
9 years, 4 months ago (2011-08-22 19:46:01 UTC) #6
tony
On 2011/08/22 19:46:01, asvitkine_ wrote: > > 20k seems like a lot of size to ...
9 years, 4 months ago (2011-08-22 19:47:07 UTC) #7
Alexei Svitkine (slow)
> You can wrap it in an <if expr="is_macosx"></if>. There are examples of this in ...
9 years, 4 months ago (2011-08-22 19:52:59 UTC) #8
tony
LGTM
9 years, 4 months ago (2011-08-22 20:29:49 UTC) #9
commit-bot: I haz the power
9 years, 4 months ago (2011-08-23 02:12:25 UTC) #10
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 97755, job name
was 7711007-3005 (previous was lost) (retry) (previous was lost) (previous was
lost).

Powered by Google App Engine
This is Rietveld 408576698